Add feature-gated Swift string and buffer APIs - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers currently have to build Swift string construction and temporary Unicode buffers around the low-level C API. Add handwritten
Stringand counted-buffer conveniences so that code can live in this package and survive upstream binding regeneration.OptionSet.Validation: all 13 feature configurations passed runtime tests, native symbol checks, and positive/negative external Swift API probes; all 28 tests passed in Release and with Address Sanitizer. Xcode Release builds passed for arm64 and x86_64 iOS Simulator. All Swift sources typechecked for x86_64 macOS 10.13 with every feature enabled. GitHub CI passed on macOS (including Address Sanitizer) and Linux with the minimum Swift 6.1 toolchain.
Publish these APIs as package version
1.0.1. Nitro #103 adopts the new methods and will use the versioned release.