Repository navigation
Conversation
Author
|
Thread count on a Pixel 8 Pro, from
Harness runs on the same device: both new tests fail on the baseline APK and pass with the fix (hooks and frame suites, 19 passed, 3 skipped). The two camera-view failures (initial zoom, initial torch) fail on the baseline too. |
|
@chocky335 is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On Android, each frame output keeps its
com.margelo.camera.framethread after the camera closes, so every camera mount leaks one thread.How
HybridFrameOutputandHybridDepthFrameOutputnow shut their executor down indispose().useFrameOutputdisposes its output on unmount or replacement, one microtask late so a StrictMode effect re-run keeps it alive.Review focus: the hook disposes the output while
<Camera>may still have it configured until its teardownconfigure([])runs.The thread test comes from #4212 by @dmandrade. It stays red on iOS until
HybridNativeThread.swiftrejects work after dispose. I can follow up with that, and with the same unmount dispose inuseDepthOutput.Closes #4213
Related Pull Requests
useFrameOutput.ts(merges cleanly) and conflicts invisioncamera.hooks.harness.tsx