Repository navigation
Feat/output rotation degrees - #4224
Draft
ismaelsousa wants to merge 4 commits into
Draft
ismaelsousa wants to merge 4 commits into
ismaelsousa wants to merge 4 commits into
Conversation
Store and forward outputOrientation to Preview.targetRotation so CameraX updates ResolutionInfo for the new target orientation. This keeps resolutionInfo.rotationDegrees synchronized instead of leaving it based on the default rotation.
|
@ismaelsousa is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for reporting the rotation angle (in degrees) of camera outputs on both Android and iOS. This allows consumers of the camera API to know how much the camera buffer needs to be rotated to match the desired output orientation. The change includes updates to the native modules, platform-specific output classes, and the TypeScript interface.
Rotation Degrees Support
rotationDegreesproperty to theCameraOutputTypeScript interface to expose the clockwise rotation (in degrees) needed to transform the native buffer to the target output orientation.rotationDegreesproperty in all relevant Android output classes (HybridPreviewOutput,HybridPhotoOutput,HybridVideoOutput,HybridFrameOutput,HybridDepthFrameOutput,HybridBarcodeScannerOutput) by reading from the platform's resolution info. [1] [2] [3] [4] [5] [6]rotationDegreesproperty in all relevant iOS output classes by extendingAVCaptureConnectionand exposing the rotation angle (iOS 17+). [1] [2] [3] [4] [5] [6] [7] [8] [9]Android Output Orientation Handling
HybridPreviewOutputto properly set the target rotation on the preview whenoutputOrientationis changed, ensuring the preview aligns with the specified orientation. [1] [2]iOS Foundation Extension
AVCaptureConnectionto expose therotationDegreesproperty, using the nativevideoRotationAngleon iOS 17+.These changes ensure that all camera output types consistently report their rotation angle, improving the ability to correctly orient camera frames across platforms.