feat: type-safe TensorDataType enum, upgrade LiteRT to 2.1.3, address PR #172 review comments - #175
Closed
DaveyEke wants to merge 2 commits into
Closed
feat: type-safe TensorDataType enum, upgrade LiteRT to 2.1.3, address PR #172 review comments#175DaveyEke wants to merge 2 commits into
DaveyEke wants to merge 2 commits into
Conversation
DaveyEke
commented
Mar 27, 2026
DaveyEke
commented
Contributor
- Tensor.dataType changed from string → TensorDataType discriminated union (20 types, nitrogen-generated C++ enum)
- All switch statements made exhaustive (no default: fallthrough)
- LiteRT Android upgraded 1.4.0 → 2.1.3, GPU delegate 1.4.0 → 1.4.2
- ArrayBuffer.copy → ArrayBuffer.wrap (GC-safe) — addresses PR feat: migrate to Nitro Modules (v3) #172 review
- Removed 16KB page-size linker flags (handled by Gradle now) — addresses PR feat: migrate to Nitro Modules (v3) #172 review
- Example app bundle ID + module name standardised to com.margelo.nitro.tflite.example / TFLiteExample
… PR margelo#172 review comments
DaveyEke
marked this pull request as draft
March 27, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.