Serialize tab selections during active transitions - #127
Open
apples-kksk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52 by queuing tab selection changes while UIKit is still completing the current transition. The latest requested tab is applied after the active transition finishes, which avoids overlapping transitions from rapid swipes, tab taps, or programmatic selection changes.
This also adds example stress modes and UI coverage for rapid
selectedIndex/selectedViewControllerchanges.Validation
git diff --checkxcodebuild testpassed in fork CI on macOS 15: https://github.com/apples-kksk/SwipeableTabBarController/actions/runs/25959356486IssueHunt Summary
Referenced issues
This pull request has been submitted to: