Add Audition CI checks - #2286
Closed
joelhawksley wants to merge 3 commits into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d482578-5711-4d80-bb76-acd088a3a746
github-actions
Bot
added
ruby
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d482578-5711-4d80-bb76-acd088a3a746
Keep Audition's Rubydex RBI files out of Sorbet's bundled dependency scan. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d482578-5711-4d80-bb76-acd088a3a746
joelhawksley
marked this pull request as ready for review
August 18, 2026 20:17
marcoroth
marked this pull request as draft
August 21, 2026 03:31
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds Audition, a linter for enforcing Ractor compatilibilty. It also fixes a few low-hanging fruit.
Summary
Testing
bundle exec rubocop lib/herb/bootstrap.rb lib/herb/cli.rb lib/herb/engine/error_formatter.rb lib/herb/engine/validation_error_overlay.rb lib/herb/project.rbbundle exec rake test:engine test:integrationbundle exec audition . --static-only --format github