Ruby: Reform RBS signatures of lex_file and parse_file - #2233
Open
elizamarcum wants to merge 4 commits into
Open
Ruby: Reform RBS signatures of lex_file and parse_file#2233elizamarcum wants to merge 4 commits into
lex_file and parse_file#2233elizamarcum wants to merge 4 commits into
Conversation
lex_file and parse_file
marcoroth
reviewed
Aug 15, 2026
marcoroth
left a comment
Owner
There was a problem hiding this comment.
Awesome, thank you so much @elizamarcum, this is exactly the right approach in my option. A few things:
- I think we also need to match the signatures for
parseandlexinsig/herb_c_extension.rbs(or maybe it already perfectly matches?). - In order to get the RBS signarures in
sig/*re-generated you need to runbundle exec rake rbs_inline, so that it looks at all the RBS inline comments in the Ruby files and writes the matching*.rbsfile for it. - Great catch about the
Brewfilechanges, I guess I never caught these, since I somehow already had a matching Python+Ruby version installed already, feel free to keep the changes in here. 馃檶馃徏
Thank you so much for the contribution! 馃檹馃徏
elizamarcum
force-pushed
the
main
branch
2 times, most recently
from
August 26, 2026 17:08
104698e to
fe33bed
Compare
elizamarcum
commented
Aug 26, 2026
marcoroth
reviewed
Aug 26, 2026
marcoroth
reviewed
Aug 26, 2026
elizamarcum
force-pushed
the
main
branch
2 times, most recently
from
August 27, 2026 18:54
9cd0b33 to
890e8af
Compare
marcoroth
reviewed
Aug 27, 2026
Alternative approach based on PR review notes on marcoroth#1990
Co-authored-by: Marco Roth <marco.roth@intergga.ch> Signed-off-by: Eliza Brock Marcum <eliza@elizamarcum.com>
Owner
|
@elizamarcum we need one more |
Co-authored-by: Marco Roth <marco.roth@intergga.ch> Signed-off-by: Eliza Brock Marcum <eliza@elizamarcum.com>
Author
|
@marcoroth I think we've got it this time! 馃檲馃 |
marcoroth
approved these changes
Aug 27, 2026
marcoroth
left a comment
Owner
There was a problem hiding this comment.
Looks great, thank you so much @elizamarcum! 馃檹馃徏
marcoroth
enabled auto-merge (squash)
August 27, 2026 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lex_fileandparse_file聽#1990lex_fileandparse_file聽#1990, but I'm happy to tweak this if it isn't quite what you were hoping for :)Brewfilethat were necessary for developing against this codebase