Language Service: Implement Semantic Token Provider - #2227
Draft
marcoroth wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as WIP.
This pull request implements
textDocument/semanticTokens, so an editor colors HTML+ERB from the parsed template rather than from a TextMate/Tree Sitter grammar guessing at it with regexes.A grammar has to decide what
<div class="a <%= b %>">is by looking at characters. Herb already knows, so the tokens it hands back stay right where nesting gets awkward, and they carry things no grammar could work out at all, like whether a helper came from Action View or from the application.What it claims, and what it leaves alone
typepropertystring<><//><%%>macrooutputmodifier on<%=<!-- -->and<%# %>comment<!DOCTYPE>keywordkeywordfunctiondefaultLibrarymodifierlocals:declarationparameterThe Ruby inside a tag is deliberately almost untouched. A Ruby language server describes it far better.