Parser: Properly handle asset tag helper options and duplicate sources - #2155
Draft
marcoroth wants to merge 1 commit into
Draft
Parser: Properly handle asset tag helper options and duplicate sources#2155marcoroth wants to merge 1 commit into
marcoroth wants to merge 1 commit into
Conversation
Rails removes several options from the tag attributes before rendering, which neither `javascript_include_tag` nor `stylesheet_link_tag` accounted for. `nopush` and `preload_links_header` are deleted from the options hash and only feed the Early Hints link header, so they are now stripped instead of being rendered as attributes. `crossorigin` is also deleted, normalized so that `true` becomes `"anonymous"`, and reinserted second in the base hash for both helpers. `integrity` is read without being deleted, so it stays where the caller wrote it. Rails calls `sources.uniq` before mapping, so duplicate sources now collapse into a single element. Sources compare as string literals by their unescaped value and as expressions by their source text. Placing `crossorigin` correctly for `javascript_include_tag` required fixing its single source attribute ordering, which appended `src` last while the multi source path already emitted it first. Both paths now emit `src` first, matching Rails. The `data attributes` engine test matches Rails exactly as a result and was promoted from `assert_optimized_mismatch_snapshot` to `assert_optimized_snapshot`.
github-actions
Bot
added
typescript
馃尶 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 馃尡 Grown from commit |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails removes several options from the tag attributes before rendering, which neither
javascript_include_tagnorstylesheet_link_tagaccounted for.