Skip to content

Silence the 'surround' unknown-config-key warning for pre-#432 edits #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcinz606 merged 1 commit into from
Jul 12, 2026
+7 −1
Merged

Silence the 'surround' unknown-config-key warning for pre-#432 edits #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion negpy/domain/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,13 @@ def from_flat_dict(cls, data: Dict[str, Any]) -> "WorkspaceConfig":
for cc in config_classes:
valid_keys.update(cc.__dataclass_fields__.keys())

unknown = set(data) - valid_keys
# Fields deliberately removed from the config over time. Every edit saved
# before the removal still carries them, so they'd otherwise warn on every
# file load; drop silently and keep the warning for truly unknown keys.
# surround: dim-surround print gamma, removed in #432 (replaced by Snap).
legacy_keys = {"surround"}

unknown = set(data) - valid_keys - legacy_keys
if unknown:
logger.warning("Dropping unknown config keys: %s", sorted(unknown))

Expand Down
Loading