fix(business): calculate cart total with line item quantities#47
Open
emre155 wants to merge 1 commit into
Open
fix(business): calculate cart total with line item quantities#47emre155 wants to merge 1 commit into
emre155 wants to merge 1 commit into
Conversation
Updates totalCart to multiply each item's price by its quantity (defaulting to 1 if not defined) when reducing the list, fixing an undercounting bug where quantities were ignored. Closes marandaneto#26 Signed-off-by: emreumar <emreumar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the cart total calculation by multiplying each item's price by its quantity (closes #26).
Changes
totalCartinsrc/business.jsto evaluateitem.price * (item.quantity || 1)in the reduce accumulator.All related tests are now passing successfully.
Signed-off-by: emreumar emreumar@users.noreply.github.com