Skip to content

Add additional example of hashing with extension slots. - #565

Merged
cthoyt merged 4 commits into
masterfrom
more-extension-examples
Aug 1, 2026
Merged

Add additional example of hashing with extension slots.#565
cthoyt merged 4 commits into
masterfrom
more-extension-examples

Conversation

@gouttegd

@gouttegd gouttegd commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Resolves #563

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • [ ] tests have been added/updated (if applicable)
  • [ ] CHANGELOG.md has been updated.

Add one more example of hashing a mapping record containing missing types of extension values (float, boolean, date, datetime, URI).

Add one more example of hasing a mapping record containing missing types
of extension values (float, boolean, date, datetime, URI).

closes #563
@gouttegd gouttegd self-assigned this Jul 31, 2026
Comment thread src/docs/spec-support-hashing.md
Comment thread src/docs/spec-support-hashing.md Outdated
gouttegd added 3 commits July 31, 2026 15:59
The XMLSchema datatype for a date/time value is `xsd:dateTime`, _not_
`xsd:datetime`.
The `xsd:` and `rdfs:` prefix names do not need to be declared (they are
part of the "builtin" prefix names), but all other examples in the
hashing page declare the full list of prefix names (including the
builtin ones), so better be consistent.
Comment thread src/docs/spec-support-hashing.md

@cthoyt cthoyt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming this all works as expected, also in my implementation. thanks @gouttegd!

@gouttegd
gouttegd requested a review from matentzn July 31, 2026 22:12

@matentzn matentzn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant find anything to complain about which is disappointing

@cthoyt
cthoyt merged commit 281c527 into master Aug 1, 2026
3 checks passed
@cthoyt
cthoyt deleted the more-extension-examples branch August 1, 2026 07:46
@gouttegd

gouttegd commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Cant find anything to complain about which is disappointing

:D Sorry, next time I’ll make sure to introduce a mistake or two for you (but it will be up to you to catch them before @cthoyt does :p ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional examples of hashing w/ extension slots

3 participants