v3: ESM, linting, remove stale code & deps#353
Conversation
|
Hey @mourner, checking with the Map Designers, seems like no one has much context on this repo and how to approach a review here. Any guidance you can provide or are we the best team to go to for a review on this? |
|
@ohsk this repo is a collection of older Mapbox GL JS styles which is mostly used as a dev dependency for testing across GL JS related projects. It's been historically owned by the Map Design team since it contains map styles, but since we don't do any changes to the styles here anymore (the current work happens on |
|
@ohsk I can review this one for now, but I think it makes sense to have this owned by gl-js. |
| pull_request: | ||
| branches: [master] | ||
|
|
||
| on: [push, pull_request] |
There was a problem hiding this comment.
Does this need to run on push as well without a PR created?
| @@ -0,0 +1 @@ | |||
| export {default} from 'eslint-config-mourner'; | |||
There was a problem hiding this comment.
We have also company wide eslint that you could also add here @mapbox/eslint-plugin-mapbox (it has some extra things such as flags if there are protential tokens in the code)
| var path = require('path'); | ||
| module.exports.styles = {}; | ||
| module.exports.sprites = {}; | ||
| import fs from 'node:fs'; |
There was a problem hiding this comment.
We are still using this package in core-styles and it seems that it is not easy to start using dynamic import as these are used in a constructor. Used here https://github.com/mapbox/core-styles/blob/main/lib/sprites-read.js#L20C7-L20C20 and here https://github.com/mapbox/core-styles/blob/main/lib/styles-read.js#L7. Could this support both ESM and CJS?
3 participants
"type": "module")tapewith the built-innode --testrunnertinyglobbydependency (no longer needed)makiandmapbox-gl-style-specto current versionsCHANGELOG.md(easier to maintain via GH release notes),migrate.sh, unused iconset JSONs, emptybinfield