Skip to content

fix(desktop): replace standard bindings with reflection ones #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maotovisk merged 1 commit into from
Jul 16, 2026
Merged

fix(desktop): replace standard bindings with reflection ones #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions MapWizard.Desktop/Views/ComboColourStudio/ComboColourStudioView.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
<controls:ModernColorPicker
SelectedColor="{Binding Colour, Converter={StaticResource AvaloniaColorToColorConverter}, Mode=TwoWay}" />
<Button Classes="Basic"
Command="{Binding #Root.DataContext.RemoveColourCommand}"
Command="{ReflectionBinding DataContext.RemoveColourCommand, ElementName=Root}"
CommandParameter="{Binding}"
ToolTip.Tip="Remove this combo colour">
<materialIcons:MaterialIcon Kind="Close" Width="20" Height="20" />
Expand Down Expand Up @@ -276,9 +276,9 @@
DragDrop.DragOver="SequenceToken_OnDragOver"
DragDrop.Drop="SequenceToken_OnDrop">
<controls:ComboColourDropdown
Options="{Binding #Root.DataContext.ColourDropdownOptions}"
Options="{ReflectionBinding DataContext.ColourDropdownOptions, ElementName=Root}"
SelectedComboNumber="{Binding ComboNumber, Mode=TwoWay}"
RemoveTokenCommand="{Binding #Root.DataContext.RemoveColourFromPointCommand}"
RemoveTokenCommand="{ReflectionBinding DataContext.RemoveColourFromPointCommand, ElementName=Root}"
RemoveTokenCommandParameter="{Binding}" />
</Border>
</DataTemplate>
Expand All @@ -291,21 +291,21 @@
Spacing="6"
HorizontalAlignment="Right">
<Button Classes="Basic"
Command="{Binding #Root.DataContext.AddColourToPointCommand}"
Command="{ReflectionBinding DataContext.AddColourToPointCommand, ElementName=Root}"
CommandParameter="{Binding}"
ToolTip.Tip="Add combo colour to this point sequence">
<materialIcons:MaterialIcon Kind="Add" Width="16" Height="16" />
</Button>

<Button Classes="Basic"
Command="{Binding #Root.DataContext.AddColourPointFromSequenceCommand}"
Command="{ReflectionBinding DataContext.AddColourPointFromSequenceCommand, ElementName=Root}"
CommandParameter="{Binding}"
ToolTip.Tip="Create a new colour point from this sequence">
<materialIcons:MaterialIcon Kind="ContentCopy" Width="16" Height="16" />
</Button>

<Button Classes="Basic"
Command="{Binding #Root.DataContext.RemoveColourPointCommand}"
Command="{ReflectionBinding DataContext.RemoveColourPointCommand, ElementName=Root}"
CommandParameter="{Binding}"
ToolTip.Tip="Remove this colour point">
<materialIcons:MaterialIcon Kind="Delete" Width="18" Height="18" />
Expand Down
10 changes: 5 additions & 5 deletions MapWizard.Desktop/Views/MapCleaner/MapCleanerView.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<StackPanel Orientation="Horizontal" Spacing="6">
<TextBlock VerticalAlignment="Center" Text="{Binding}" />
<Button Classes="SnapChipClose"
Command="{Binding DataContext.RemoveSnapCommand, ElementName=Root}"
Command="{ReflectionBinding DataContext.RemoveSnapCommand, ElementName=Root}"
CommandParameter="{Binding}"
ToolTip.Tip="Remove snap">
<materialIcons:MaterialIcon Kind="Close" Width="14" Height="14" />
Expand Down Expand Up @@ -139,7 +139,7 @@
FontSize="13" />
<Separator />
<ScrollViewer MaxHeight="220">
<ItemsControl ItemsSource="{Binding DataContext.SnapPresets, ElementName=Root}">
<ItemsControl ItemsSource="{ReflectionBinding DataContext.SnapPresets, ElementName=Root}">
<ItemsControl.ItemsPanel>
<ItemsPanelTemplate>
<WrapPanel />
Expand All @@ -149,7 +149,7 @@
<DataTemplate>
<Button Classes="SnapPresetBadge Compact"
Margin="0,0,6,6"
Command="{Binding DataContext.AddSnapFromFlyoutCommand, ElementName=Root}"
Command="{ReflectionBinding DataContext.AddSnapFromFlyoutCommand, ElementName=Root}"
CommandParameter="{Binding}">
<TextBlock Text="{Binding}" />
</Button>
Expand All @@ -161,9 +161,9 @@
<StackPanel Orientation="Horizontal" Spacing="8">
<TextBox Width="170"
PlaceholderText="Custom 1/x"
Text="{Binding DataContext.CustomSnapInput, Mode=TwoWay, ElementName=Root}" />
Text="{ReflectionBinding DataContext.CustomSnapInput, Mode=TwoWay, ElementName=Root}" />
<Button Classes="Basic Compact"
Command="{Binding DataContext.AddCustomSnapCommand, ElementName=Root}">
Command="{ReflectionBinding DataContext.AddCustomSnapCommand, ElementName=Root}">
<TextBlock Text="Add" />
</Button>
</StackPanel>
Expand Down
2 changes: 1 addition & 1 deletion MapWizard.Desktop/Views/MetadataManager/MetadataManagerView.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
<controls:ModernColorPicker VerticalAlignment="Center"
SelectedColor="{Binding Colour, Converter={StaticResource AvaloniaColorToColorConverter}, Mode=TwoWay}" />
<Button Classes="Basic"
Command="{Binding #Root.DataContext.RemoveColourCommand}"
Command="{ReflectionBinding DataContext.RemoveColourCommand, ElementName=Root}"
CommandParameter="{Binding}"
ToolTip.Tip="Remove this colour">
<materialIcons:MaterialIcon Kind="Close" Width="24" Height="24" />
Expand Down
Loading