Record processGroups parent history for reflectometry reductions#41345
Draft
MialLewis wants to merge 7 commits intorefactor_rroafrom
Draft
Record processGroups parent history for reflectometry reductions#41345MialLewis wants to merge 7 commits intorefactor_rroafrom
MialLewis wants to merge 7 commits intorefactor_rroafrom
Conversation
Contributor
Unit test results2 868 tests 2 867 ✅ 2h 21m 6s ⏱️ Results for commit d351792. ♻️ This comment has been updated with latest results. |
ae5cecc to
d351792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
In
Algorithm::doCallProcessGroups, the history associated with the initial call to on the group workspace is not saved on resultant output workspace. This is because historically the initial call is expected to in turn make repeated calls to the algorithm on the workspace members, which would in turn provide the history.For some workflows, such as
RelfectometryReductionOneAuto, this is not the case. If the algorithm is called on a WorkspaceGroup containing polarized data, each member of the workspace group represents a spin state. A unique polarisation analysis path is followed, where the reductions are interlinked via the calculation of the polarization efficiencies.This PR therefore adds a flag (and exposes it to python) that allows the writer of an algorithm to select how workspace history works with groups:
m_recordHistoryForProcessGroups = False-> Workspace history for initial algorithm call disregarded. History can be added to output workspaces for each individual algorithm call, if the writer so chooses.m_recordHistoryForProcessGroups = False-> Workspace history for initial algorithm call is kept, subsequent algorithms can be called as a child and their history will be rolled up into that of the parent.Closes #36985
To test:
Run these test scripts before and after these changes, see that the algorithm histories for
ReflectometryISISLoadAndProcessandReflectometryReductionOneAutoand nicely rolled up under their parents.For first test, ask for data, or second test use test data.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: