More elf os detection cases#3099
Open
williballenthin wants to merge 2 commits into
Open
Conversation
to better support ports of this logic to other languages/runtimes
Collaborator
Author
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite in tests/test_elf_os_detection.py to validate ELF OS detection algorithms against multiple test fixtures, and updates the CHANGELOG.md to reflect these additions. The review feedback recommends defining the FIXTURES dataset directly as a native Python list of dictionaries rather than parsing a raw JSON string at runtime, which would also allow for the removal of the unused json import.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+38
to
+159
| FIXTURES = json.loads( | ||
| """ | ||
| [ | ||
| { | ||
| "path": "2f7f5fb5de175e770d7eae87666f9831.elf_", | ||
| "os": "linux", | ||
| "algorithms": { | ||
| "sh_notes": "linux", | ||
| "ident_directive": "linux", | ||
| "vdso_strings": "linux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "7351f8a40c5450557b24622417fc478d.elf_", | ||
| "os": "linux", | ||
| "algorithms": { | ||
| "ph_notes": "linux", | ||
| "sh_notes": "linux", | ||
| "ident_directive": "linux", | ||
| "linker": "linux", | ||
| "abi_versions_needed": "linux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "b5f0524e69b3a3cf636c7ac366ca57bf5e3a8fdc8a9f01caf196c611a7918a87.elf_", | ||
| "os": "hurd", | ||
| "algorithms": { | ||
| "sh_notes": "hurd", | ||
| "abi_versions_needed": "hurd", | ||
| "needed_dependencies": "hurd" | ||
| } | ||
| }, | ||
| { | ||
| "path": "bf7a9c8bdfa6d47e01ad2b056264acc3fd90cf43fe0ed8deec93ab46b47d76cb.elf_", | ||
| "os": "hurd", | ||
| "algorithms": { | ||
| "sh_notes": "hurd", | ||
| "abi_versions_needed": "hurd" | ||
| } | ||
| }, | ||
| { | ||
| "path": "2bf18d0403677378adad9001b1243211.elf_", | ||
| "os": "linux", | ||
| "algorithms": { | ||
| "symtab": "linux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "1038a23daad86042c66bfe6c9d052d27048de9653bde5750dc0f240c792d9ac8.elf_", | ||
| "os": "android", | ||
| "algorithms": { | ||
| "ph_notes": "android", | ||
| "needed_dependencies": "android" | ||
| } | ||
| }, | ||
| { | ||
| "path": "3da7c2c70a2d93ac4643f20339d5c7d61388bddd77a4a5fd732311efad78e535.elf_", | ||
| "os": "linux", | ||
| "algorithms": { | ||
| "go_buildinfo": "linux", | ||
| "go_source": "linux", | ||
| "vdso_strings": "linux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "9486f2c5d514c1f39833b852ab03f4c0297e9e82b456b0dccad1a2d7d15c3385.elf_", | ||
| "os": "freebsd", | ||
| "algorithms": { | ||
| "osabi": "freebsd" | ||
| } | ||
| }, | ||
| { | ||
| "path": "a72ac9f1cf6cc01103765f866aae2dd85ea48208fb180c01076ca982684a4032.elf_", | ||
| "os": "openbsd", | ||
| "algorithms": { | ||
| "osabi": "openbsd" | ||
| } | ||
| }, | ||
| { | ||
| "path": "5e4263575796c6ea2445505a843e616111e0e540ec49441e3bb3fc99be7d3afb.elf_", | ||
| "os": "hpux", | ||
| "algorithms": { | ||
| "osabi": "hpux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "ccb5eefc47d09672c6d62368a55f48a80259b1408b4f3d260b131d40b487f262.elf_", | ||
| "os": "linux", | ||
| "algorithms": { | ||
| "ident_directive": "linux", | ||
| "vdso_strings": "linux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "c2b2d7cea94179e6c2b6913205e37c45b67ccc0156d8f266548f7f1f95144285.elf_", | ||
| "os": "linux", | ||
| "algorithms": { | ||
| "ph_notes": "linux", | ||
| "linker": "linux" | ||
| } | ||
| }, | ||
| { | ||
| "path": "fb5cf3df103336ca6b84a5d0f314bdd394ce7465adac3cf1914d390d62884582.elf_", | ||
| "os": "freebsd", | ||
| "algorithms": { | ||
| "osabi": "freebsd", | ||
| "go_source": "freebsd" | ||
| } | ||
| }, | ||
| { | ||
| "path": "ef0ef9693ac433b768dc4cd260132788c3d95afa12addab711c15de61f3631bf.elf_", | ||
| "os": "openbsd", | ||
| "algorithms": { | ||
| "osabi": "openbsd", | ||
| "ph_notes": "openbsd", | ||
| "sh_notes": "openbsd", | ||
| "go_buildinfo": "openbsd" | ||
| } | ||
| } | ||
| ] | ||
| """ | ||
| ) |
Contributor
There was a problem hiding this comment.
Defining FIXTURES as a raw JSON string and parsing it at runtime with json.loads is unnecessary and introduces import-time overhead. Additionally, it prevents static analysis tools (like linters, formatters, and type checkers) from validating and formatting the fixture data.
It is highly recommended to define FIXTURES directly as a native Python list of dictionaries.
FIXTURES = [
{
"path": "2f7f5fb5de175e770d7eae87666f9831.elf_",
"os": "linux",
"algorithms": {
"sh_notes": "linux",
"ident_directive": "linux",
"vdso_strings": "linux",
},
},
{
"path": "7351f8a40c5450557b24622417fc478d.elf_",
"os": "linux",
"algorithms": {
"ph_notes": "linux",
"sh_notes": "linux",
"ident_directive": "linux",
"linker": "linux",
"abi_versions_needed": "linux",
},
},
{
"path": "b5f0524e69b3a3cf636c7ac366ca57bf5e3a8fdc8a9f01caf196c611a7918a87.elf_",
"os": "hurd",
"algorithms": {
"sh_notes": "hurd",
"abi_versions_needed": "hurd",
"needed_dependencies": "hurd",
},
},
{
"path": "bf7a9c8bdfa6d47e01ad2b056264acc3fd90cf43fe0ed8deec93ab46b47d76cb.elf_",
"os": "hurd",
"algorithms": {
"sh_notes": "hurd",
"abi_versions_needed": "hurd",
},
},
{
"path": "2bf18d0403677378adad9001b1243211.elf_",
"os": "linux",
"algorithms": {
"symtab": "linux",
},
},
{
"path": "1038a23daad86042c66bfe6c9d052d27048de9653bde5750dc0f240c792d9ac8.elf_",
"os": "android",
"algorithms": {
"ph_notes": "android",
"needed_dependencies": "android",
},
},
{
"path": "3da7c2c70a2d93ac4643f20339d5c7d61388bddd77a4a5fd732311efad78e535.elf_",
"os": "linux",
"algorithms": {
"go_buildinfo": "linux",
"go_source": "linux",
"vdso_strings": "linux",
},
},
{
"path": "9486f2c5d514c1f39833b852ab03f4c0297e9e82b456b0dccad1a2d7d15c3385.elf_",
"os": "freebsd",
"algorithms": {
"osabi": "freebsd",
},
},
{
"path": "a72ac9f1cf6cc01103765f866aae2dd85ea48208fb180c01076ca982684a4032.elf_",
"os": "openbsd",
"algorithms": {
"osabi": "openbsd",
},
},
{
"path": "5e4263575796c6ea2445505a843e616111e0e540ec49441e3bb3fc99be7d3afb.elf_",
"os": "hpux",
"algorithms": {
"osabi": "hpux",
},
},
{
"path": "ccb5eefc47d09672c6d62368a55f48a80259b1408b4f3d260b131d40b487f262.elf_",
"os": "linux",
"algorithms": {
"ident_directive": "linux",
"vdso_strings": "linux",
},
},
{
"path": "c2b2d7cea94179e6c2b6913205e37c45b67ccc0156d8f266548f7f1f95144285.elf_",
"os": "linux",
"algorithms": {
"ph_notes": "linux",
"linker": "linux",
},
},
{
"path": "fb5cf3df103336ca6b84a5d0f314bdd394ce7465adac3cf1914d390d62884582.elf_",
"os": "freebsd",
"algorithms": {
"osabi": "freebsd",
"go_source": "freebsd",
},
},
{
"path": "ef0ef9693ac433b768dc4cd260132788c3d95afa12addab711c15de61f3631bf.elf_",
"os": "openbsd",
"algorithms": {
"osabi": "openbsd",
"ph_notes": "openbsd",
"sh_notes": "openbsd",
"go_buildinfo": "openbsd",
},
},
]
Collaborator
Author
There was a problem hiding this comment.
this is inline JSON so that it can be subsequently extracted into its own standalone JSON file later.
Comment on lines
+15
to
+16
| import json | ||
| from pathlib import Path |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mr-tz
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review after #3098
uses new ELF test files from mandiant/capa-testfiles#313
Used Claude and VT to collect these files and construct the test cases.
Checklist