test: cover TransformGroup apply paths (positions + scales)#34
Merged
Conversation
Adds PlayMode coverage for the previously-untested multi-target apply methods: - UpdatePositions offsets every member by the delta - UpdateScales pivot-origin adds to localScale and leaves position - UpdateScales center-origin (IsOriginOnCenter + renderer branch) scales a centered cube in place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #26 (test coverage). Adds PlayMode coverage for the previously-untested multi-target apply methods in
TransformGroup:UpdatePositionsoffsets every member by the deltaUpdateScalespivot-origin: adds tolocalScale, leaves positionUpdateScalescenter-origin: exercises theIsOriginOnCenter+ renderer branch (scales a centered cube in place)test:only + underTests/→ excluded from the bump filter (#29) → no release on merge.Note
Low Risk
Test-only changes under Tests/ with no production or runtime behavior changes.
Overview
Adds PlayMode tests in
TransformGroupTestsfor multi-target apply behavior onTransformGroupthat was not covered before (rotation tests already existed).New coverage checks that
UpdatePositionsapplies the same world delta to every group member, and thatUpdateScalesbehaves correctly for pivot-origin targets (adds tolocalScale, position unchanged) and center-origin targets with a renderer (primitive cube stays in place while scale increases). A smallNewCubehelper creates a primitive cube with aMeshRendererfor the center-origin case.Reviewed by Cursor Bugbot for commit 5509a14. Bugbot is set up for automated code reviews on this repo. Configure here.