Skip to content

Fixes a code generation bug failed to generate the required XName fields in a C# class for an element #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mamift merged 16 commits into from
Jun 6, 2026
Merged

Fixes a code generation bug failed to generate the required XName fields in a C# class for an element #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
34263d8
Added ParaParse schema for testing.
mamift Jun 2, 2026
646a778
Fixes a bug that occurs with generated code where if the chosen names…
mamift Jun 2, 2026
d160ddc
added to solution filter.
mamift Jun 3, 2026
ae9bf3e
semantic rename and reformat code.
mamift Jun 3, 2026
a0984c7
Refactored getSymbol to keep track if incrementing a symbol identifie…
mamift Jun 4, 2026
bb2ac25
added minimal reproducible example for the bad xname code generation …
mamift Jun 4, 2026
e59e95f
fixed wrong logic.
mamift Jun 5, 2026
dffa311
reformatted for readability.
mamift Jun 5, 2026
aa15c65
Oops, this was still wrong. now its right.
mamift Jun 5, 2026
b689505
All xname fields are getting generated properly!
mamift Jun 5, 2026
bcc0ad3
Regenerated code, re-ran test; all works fine!
mamift Jun 5, 2026
182bae0
Updated version and release notes.
mamift Jun 5, 2026
adb0a84
Potential fix for pull request finding
mamift Jun 5, 2026
49fd373
typos.
mamift Jun 5, 2026
cd17afb
this test always fails when part of the larger suite, but succeeds on…
mamift Jun 5, 2026
c9f9632
updated release notes.
mamift Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions GeneratedSchemaLibraries/ParaParserXml/ParaParserXml.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="paraparse_xNameBug.xsd" />
<EmbeddedResource Include="paraparse.xsd" />
<EmbeddedResource Include="paraparse.xsd.config" />
<EmbeddedResource Include="paraparse.xsd.cs" />
</ItemGroup>
<ItemGroup>
<None Remove="paraparse_xNameBug.xsd" />
<None Remove="paraparse.xsd" />
<None Remove="paraparse.xsd.config" />
</ItemGroup>
Comment thread
mamift marked this conversation as resolved.
<ItemGroup>
<ProjectReference Include="..\..\XObjectsCore\XObjectsCore.csproj">
<SetTargetFramework>TargetFramework=netstandard2.0</SetTargetFramework>
</ProjectReference>
</ItemGroup>
</Project>
208 changes: 208 additions & 0 deletions GeneratedSchemaLibraries/ParaParserXml/paraparse.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,208 @@
<?xml version="1.0" encoding="utf-8"?>
<xs:schema id="paraparse" targetNamespace="urn:ParaParse.XML" elementFormDefault="qualified"
xmlns="urn:ParaParse.XML" xmlns:xs="http://www.w3.org/2001/XMLSchema">

<xs:complexType name="Rule" abstract="true">
<xs:attribute name="Name" type="xs:string" use="optional"/>
</xs:complexType>

<xs:element name="Rule" type="Rule" abstract="true"/>

<xs:group name="RuleGroup">
<xs:choice>
<xs:element ref="NamedRule"/>
<xs:element ref="RecursiveRule"/>
<xs:element ref="StringRule"/>
<xs:element ref="CaseInvariantStringRule"/>
<xs:element ref="AnyCharRule"/>
<xs:element ref="CharRangeRule"/>
<xs:element ref="CharSetRule"/>
<xs:element ref="CharRule"/>
<xs:element ref="EndOfInputRule"/>
<xs:element ref="NodeRule"/>
<xs:element ref="ZeroOrMoreRule"/>
<xs:element ref="OneOrMoreRule"/>
<xs:element ref="CountedRule"/>
<xs:element ref="OptionalRule"/>
<xs:element ref="SequenceRule"/>
<xs:element ref="ChoiceRule"/>
<xs:element ref="AtRule"/>
<xs:element ref="NotAtRule"/>
<xs:element ref="OnFail"/>
<xs:element ref="BooleanRule"/>
</xs:choice>
</xs:group>

<xs:complexType name="SingleChildRule">
<xs:complexContent>
<xs:extension base="Rule">
<xs:sequence>
<xs:group ref="RuleGroup"/>
</xs:sequence>
</xs:extension>
</xs:complexContent>
</xs:complexType>

<xs:complexType name="MultiChildRule">
<xs:complexContent>
<xs:extension base="Rule">
<xs:sequence minOccurs="0" maxOccurs="unbounded">
<xs:group ref="RuleGroup"/>
</xs:sequence>
</xs:extension>
</xs:complexContent>
</xs:complexType>

<!-- Concrete Rules -->

<xs:element name="NamedRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="SingleChildRule">
<xs:attribute name="RuleName" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="RecursiveRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule"/>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="StringRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:attribute name="Pattern" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="CaseInvariantStringRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:attribute name="Pattern" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="AnyCharRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule"/>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="CharRangeRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:attribute name="From" type="xs:string" use="required"/>
<xs:attribute name="To" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="CharSetRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:attribute name="Chars" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="CharRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:attribute name="Char" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="EndOfInputRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule"/>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="NodeRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="SingleChildRule">
<xs:attribute name="NodeName" type="xs:string" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="ZeroOrMoreRule" type="SingleChildRule" substitutionGroup="Rule"/>

<xs:element name="OneOrMoreRule" type="SingleChildRule" substitutionGroup="Rule"/>

<xs:element name="CountedRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="SingleChildRule">
<xs:attribute name="Min" type="xs:int" use="required"/>
<xs:attribute name="Max" type="xs:int" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="OptionalRule" type="SingleChildRule" substitutionGroup="Rule"/>

<xs:element name="SequenceRule" type="MultiChildRule" substitutionGroup="Rule"/>

<xs:element name="ChoiceRule" type="MultiChildRule" substitutionGroup="Rule"/>

<xs:element name="AtRule" type="SingleChildRule" substitutionGroup="Rule"/>

<xs:element name="NotAtRule" type="SingleChildRule" substitutionGroup="Rule"/>

<xs:element name="OnFail" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:sequence>
<xs:group ref="RuleGroup"/>
</xs:sequence>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="BooleanRule" substitutionGroup="Rule">
<xs:complexType>
<xs:complexContent>
<xs:extension base="Rule">
<xs:attribute name="Value" type="xs:boolean" use="required"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
</xs:element>

<xs:element name="grammar">
<xs:complexType>
<xs:sequence maxOccurs="unbounded">
<xs:group ref="RuleGroup"/>
</xs:sequence>
</xs:complexType>
</xs:element>

</xs:schema>
13 changes: 13 additions & 0 deletions GeneratedSchemaLibraries/ParaParserXml/paraparse.xsd.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<Configuration xmlns="http://www.microsoft.com/xml/schema/linq">
<Namespaces>
<Namespace DefaultVisibility="public" Schema="urn:ParaParse.XML" Clr="ParaParse.Xml" />
</Namespaces>
<NullableReferences>false</NullableReferences>
<Validation>
<VerifyRequired>false</VerifyRequired>
</Validation>
<Transformation>
<Deanonymize strict="false" />
</Transformation>
</Configuration>
Loading
Loading