Fix rolling accessory location history fetching#252
Open
hackermengzhi wants to merge 1 commit into
Open
Conversation
hackermengzhi
force-pushed
the
fix/full-rolling-location-history
branch
from
0408b0f to
f0e31e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_location_history()fetch the full rolling key history by defaultfetch_location()on the faster latest-only path explicitlyWhy
LocationReportsFetcher.fetch_location_history()accepted aRollingKeyPairSource, but internally always passedonly_latest=Trueto_fetch_accessory_reports(). That meant callers asking for history could silently get only the newest report batch for rolling accessories.This keeps the public history method aligned with its name while preserving current-location performance through
fetch_location().Tests
.venv/bin/python -m pytest tests/test_reports.py tests/test_keygen.py.venv/bin/python -m ruff check findmy/reports/account.py findmy/reports/reports.py tests/test_reports.py