Compute and plot inversion frequencies#1282
Open
31puneet wants to merge 26 commits into
Open
Conversation
… into 652-karyotype-frequencies
Contributor
Author
|
Hi @jonbrenas |
jonbrenas
requested changes
Apr 14, 2026
jonbrenas
left a comment
jonbrenas
left a comment
Collaborator
There was a problem hiding this comment.
If tests are added in test_inversion_frq.py, we don't need the whole test suite in test_ag3.py.
Contributor
Author
Done! |
jonbrenas
previously approved these changes
Apr 14, 2026
…652-karyotype-frequencies
Contributor
Author
|
Hi @jonbrenas PTAL |
Contributor
Author
|
Hi @jonbrenas, is this PR still okay for merge? |
Collaborator
|
Hi @31puneet, I am going to give it a new review but the plan is still to merge it in the not too distant future. |
jonbrenas
requested changes
May 28, 2026
Contributor
Author
|
Hi @jonbrenas Could we merge this pr? |
Collaborator
|
Hi @31puneet. Merging will take place after a discussion (offline) between the code owners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
inversion_frequenciesto resolve #652, and replace PR #732. I have added the following refactoring and tests to finalize the feature:inversion_frequenciesandinversion_frequencies_advancedanalogous to SNP calculations.test_inversion_frq.py