fix: [bug]: network (project visibility) is silently ignored on create/upda... - #9656
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe project creation serializer now includes the ChangesProject network field
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change enables project visibility settings to be accepted and persisted during create and update requests, with invalid values rejected by normal validation; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #9576
Root cause
networkmissing from public API project serializer field listChanges
networktoProjectCreateSerializer.Meta.fields(inherited byProjectUpdateSerializer), so POST/PATCH on /api/v1/workspaces/{slug}/projects/ now accept and persist the field; DRF's generated ChoiceField validates against Project.NETWORK_CHOICES (0/2) and rejects invalid values with a 400.Summary by CodeRabbit