[SILO-1523] feat(plane-enterprise): add integration event stream env vars + integration-event-consumer deployment - #302
Conversation
…vars + integration-event-consumer deployment Wires the new integration-event-stream env vars (INTEGRATION_EVENT_* on app-vars/silo-vars) and adds an integration-event-consumer Deployment, following the existing webhook-consumer/agent-consumer pattern (reuses the backend image, runs ./bin/docker-entrypoint-integration-event-consumer.sh). Bumps chart version to 3.6.0. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe Helm chart adds integration event ingestion settings, shared stream configuration, an optional integration event consumer Deployment, and related ConfigMaps. The chart version changes to ChangesIntegration event consumer
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The chart adds optional integration-event configuration and a consumer deployment that remains disabled by default; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
| version: 3.5.4 | ||
| appVersion: "3.1.4" | ||
| version: 3.6.0 | ||
| appVersion: "3.1.2" |
What
Adds the
integration-event-streamfeature's env vars tocharts/plane-enterprise, and a newintegration-event-consumerDeployment + ConfigMap.values.yaml/questions.yml: newservices.integration_event_consumerblock (enabled/replicas/resources),env.integration_event_consumer_envs(queue name + prefetch),env.integration_event_envs(exchange name, publish/republish/cleaner tuning), and three new keys onenv.silo_envsfor Silo's ingest side.templates/config-secrets/app-env.yaml: addsINTEGRATION_EVENT_STREAM_EXCHANGE_NAME,INTEGRATION_EVENT_CONSUMER_QUEUE_NAME,INTEGRATION_EVENT_CONSUMER_PREFETCH,INTEGRATION_EVENT_MAX_RAW_BYTES,INTEGRATION_EVENT_PUBLISH_TIMEOUT,INTEGRATION_EVENT_PUBLISH_MAX_RETRIES,INTEGRATION_EVENT_PUBLISH_RETRY_DELAY,INTEGRATION_EVENT_REPUBLISH_BATCH_SIZE,INTEGRATION_EVENT_REPUBLISH_MAX_ATTEMPTS,INTEGRATION_EVENT_REPUBLISH_GRACE_SECONDS,INTEGRATION_EVENT_CLEANER_BATCH_SIZE,INTEGRATION_EVENT_CLEANER_CUTOFF_DAYS,INTEGRATION_EVENT_COLLECTION_NAMEto the sharedapp-varsConfigMap (consumed by api/worker/beat-worker via their existingenvFrom).templates/config-secrets/silo.yaml: addsINTEGRATION_EVENT_INGEST_ENABLED,INTEGRATION_EVENT_PROVIDERS,INTEGRATION_EVENT_INGEST_TIMEOUT_MStosilo-vars.templates/config-secrets/integration-event-consumer.yaml+templates/workloads/integration-event-consumer.deployment.yaml: a dedicated Deployment that reuses the backend image and runs./bin/docker-entrypoint-integration-event-consumer.sh, mirroring the existingwebhook-consumer/agent-consumerpattern exactly (own ConfigMap first inenvFrom, thenapp-vars, app/doc-store/opensearch/silo secrets, otel hooks, readinessProbe viapgrep -f "python").Chart.yamlversion3.5.1 → 3.6.0.Why
plane-ee's new Integration Event Stream feature (normalized provider-webhook events on a durable RabbitMQ exchange) ships with its own env vars and a reference consumer container (
run_integration_event_consumer) that this chart didn't yet expose.Scope / behavior
services.integration_event_consumer.enableddefaults tofalse— nothing new deploys unless explicitly turned on.INTEGRATION_EVENT_*vars land onapp-vars/silo-varsunconditionally, but they're inert until the app code reads them (the Django settings/Silo env already default to the same values if unset), so api/worker/beat-worker behavior doesn't change beyond gaining these keys.INTEGRATION_EVENT_INGEST_ENABLEDdefaults to"0"— ingest stays off.Testing
helm lint charts/plane-enterprise(viaalpine/helm:3.14.0in Docker) — 0 failures.helm template ... --set services.integration_event_consumer.enabled=true --set services.silo.enabled=true— confirmed the new ConfigMap, Deployment, and allINTEGRATION_EVENT_*keys render as expected.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Chores