fix(plane-enterprise): mc alias set + configurable busybox image for MinIO - #299
Merged
Conversation
…alias set, bump to 3.3.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
akshat5302
changed the title
akshat5302
force-pushed
the
fix/minio-ee-mc-alias
branch
from
August 20, 2026 08:06
7ab952c to
5203e87
Compare
…t container Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
akshat5302
force-pushed
the
fix/minio-ee-mc-alias
branch
from
August 20, 2026 08:08
5203e87 to
ad2ac38
Compare
…nio init container Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… Docker Image Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mguptahub
approved these changes
Aug 20, 2026
pratapalakshmi
added a commit
that referenced
this pull request
Aug 20, 2026
The earlier bump in this branch was a no-op: #299 had already taken 3.4.1, so the version matched master and chart-releaser (skip_existing) would have silently declined to republish -- leaving the nginx annotations fix and the TLS/nginx documentation unshipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pratapalakshmi
added a commit
that referenced
this pull request
Aug 20, 2026
…EB_URL scheme (#300) * fix(plane-ce): stop forcing TLS on the Traefik ingress, and fix WEB_URL scheme Ports #295 to plane-ce, which carried the same Traefik defect plus a second, worse one of its own. templates/ingress-traefik.yaml hardcoded HTTPS in all three IngressRoutes -- the app, the MinIO console and the RabbitMQ console. Each pinned the `websecure` entrypoint and emitted its `tls:` block outside any conditional, so a default install (tls_secret_name empty, generateCerts/createIssuer false) had no HTTP listener AND no certificate: the routes advertised <release>-ssl-cert, a Secret that templates/certs/certs.yaml only creates when createIssuer and generateCerts are both true. Traefik answers such a handshake with its built-in self-signed certificate, logs nothing and stays Ready, which is why this went unnoticed. config-secrets/app-env.yaml then hardcoded WEB_URL as "http://<appHost>" regardless of ssl.*, so even a correctly TLS-configured install served Plane over HTTPS while telling the app it lived at http://. Unlike plane-enterprise, whose WEB_URL was at least conditional, this affected the *working* configurations too. Adds the same three helpers and keeps each setting to one job: plane.chartManagedCert -> `tls:` block + entrypoint plane.tlsEnabled -> https:// scheme for WEB_URL entryPoints -> entrypoint override plus ssl.externalTermination for TLS terminated in front of Plane, and ingress.traefik.entryPoints for renamed entrypoints or the Traefik-terminated case. The nginx Ingress path already gated its `tls:` block and is untouched beyond picking up the WEB_URL fix. Render diff against master, all three routes and both ingress classes: nothing set -> 2 IngressRoutes differ (the fix) tls_secret_name -> only WEB_URL differs generateCerts+createIssuer -> only WEB_URL differs nginx, nothing set -> no change nginx, tls_secret_name -> only WEB_URL differs README gains the TLS options section with a snippet per option, the 4a/4b distinction, an nginx note, and an upgrade note covering both behaviour changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs: document the nginx TLS path on both charts The TLS options sections were Traefik-only: the table's Entrypoint column does not apply to `ingressClass: nginx`, and nothing said what ssl.externalTermination does there -- yet an ALB or nginx-ingress holding the certificate is exactly the common nginx case. Adds a matching note to both charts: options 2 and 3 emit the Ingress `tls:` block as before, option 4 emits none and only sets the URL scheme. Includes a rendered example, verified against both charts. Also records the pre-existing, TLS-unrelated render failure on that path: ingress.ingress_annotations ships commented out and templates/ingress.yaml calls `len` on it, so `ingressClass: nginx` dies with "len of nil pointer" unless at least one annotation is set. Present in both charts; #289 fixes the plane-enterprise copy, so it is only documented here, with the workaround, rather than patched twice. plane-enterprise goes to 3.4.1 so the new section actually ships -- chart-releaser runs with skip_existing, so a docs change under charts/ without a version bump is silently never republished. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: render the nginx Ingress with default (unset) annotations templates/ingress.yaml called `len` on ingress.ingress_annotations, which ships commented out, so `ingressClass: nginx` failed outright with "error calling len: len of nil pointer" on default values -- the nginx path was unusable unless you happened to set an annotation. Switches to `{{- with }}`, which skips a nil/empty map cleanly. Same one-line change in both charts, so the nginx TLS guidance added in this PR describes a path that actually renders. Picked up from #296, which made this fix for plane-ce; #289 makes the identical change to the plane-enterprise copy, so that hunk may conflict trivially. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(plane-enterprise): bump to 3.4.2 for the nginx fix and TLS docs The earlier bump in this branch was a no-op: #299 had already taken 3.4.1, so the version matched master and chart-releaser (skip_existing) would have silently declined to republish -- leaving the nginx annotations fix and the TLS/nginx documentation unshipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(plane-ce): fix doubled word in the ssl.externalTermination table row Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes to
charts/plane-enterprise/templates/workloads/minio.stateful.yaml, chart bumped to 3.3.1:Deprecated
mc config host add→mc alias set:Configurable busybox image — the init container image is no longer hardcoded:
Added
services.minio.image_busybox: busyboxtovalues.yaml, a row to the README settings table, and a Rancherquestions.ymlentry.Why
mc alias set: current
minio/mcimages no longer recognisemc config host add:Because the job ends in
exit 0, the failure is silent —mc mbcreates a local directory inside the container, prints "Bucket created successfully", and Kubernetes marks the Job Complete. Theuploadsbucket never exists on MinIO, surfacing later as broken file uploads.Busybox: the hardcoded
busyboximage forces an unauthenticated Docker Hub pull, breaking air-gapped / private-registry installs where every image must come from an internal registry.services.minio.imageandservices.minio.image_mcwere already configurable; this fills the remaining gap.Scope / behavior
mc alias settakes the same argument order;image_busyboxdefaults tobusybox.services.minio.local_setup=true. External-S3 installs are unaffected.| default "busybox"guard means pre-existing values files that don't setimage_busyboxstill renderbusybox. No upgrade action required.Testing
helm lint charts/plane-enterprise→ 1 chart linted, 0 failed.helm templateverified:image:local_setup=true)busyboxmc alias set plane-app-minio …image_busybox=my.registry/busybox:1.36my.registry/busybox:1.36local_setup=falseRelated
mc config host addwithmc alias set#288 (EE half; CE half is fix(plane-ce): configurable busybox image + mc alias set for MinIO #298)plane-enterprise🤖 Generated with Claude Code