feat(plane-ce): make busybox image configurable for plane-ce - #286
feat(plane-ce): make busybox image configurable for plane-ce#286KajdeMunter wants to merge 1 commit into
Conversation
The minio bucket job's init container used a hardcoded `busybox` image, which blocks air-gapped installs and deployments that must pull all images from a private registry. Expose it as `minio.image_busybox`, mirroring the existing `minio.image_mc` pattern, and document it in the README settings table and the Rancher questions.yml. Defaults to `busybox`, so existing values files keep working unchanged. This applies the approach from makeplane#178 (plane-enterprise) to plane-ce. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThe chart adds ChangesMinIO BusyBox image configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change makes the MinIO init-container image configurable while preserving the existing default behavior and limiting the effect to local MinIO setup. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Please test the PR and update the chart.yaml before merging |
What
Makes the
busyboximage used by the MinIO bucket job's init container configurable inplane-ce, via a newminio.image_busyboxvalue.Also adds the key to
values.yaml(defaulting tobusybox), the README settings table, andquestions.ymlfor the Rancher UI.Why
busyboxwas the only hardcoded image left in theplane-cechart — every other image (minio.image,minio.image_mc, and the app images) is already overridable. That hardcoded reference forces an unauthenticated pull from Docker Hub, which breaks:ImagePullBackOffon the init container and leave the bucket job stuck before MinIO is ever provisioned.This applies the same approach as #178 (
plane-enterprise) toplane-ce.Scope / behavior
No default behavior change.
values.yamlshipsimage_busybox: busybox, so the rendered output is byte-identical unless an operator overrides it.minio.local_setup=true— the whole template is wrapped in{{- if .Values.minio.local_setup }}. Installs using external S3 are unaffected.| default "busybox"rather than a bare value reference, so an existing values file that predates this key (or sets it empty) still rendersbusyboxinstead of an emptyimage:field. Upgrades need no values-file change.Testing
helm lint charts/plane-ce→ passes, 0 charts failed.helm templateacross the relevant value combinations:image:local_setup=true)busyboximage_busybox=my.registry/busybox:1.36my.registry/busybox:1.36image_busybox=""(simulates a pre-existing values file)busyboxlocal_setup=falseNot deployed to a live cluster — the change is a template-only substitution and the rendered manifests above cover it.
Related
plane-enterprise🤖 Generated with Claude Code