add: support for GCS related values - #230
Conversation
|
Warning Review limit reached
Next review available in: 53 seconds Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughAdds configurable storage provider support (default S3) and GCS parameters, updates the doc-store Secret template to render STORAGE_PROVIDER, SIGNED_URL_EXPIRATION, and GCS fields with validation, adds APP_BASE_URL logic to the app ConfigMap, and bumps the chart version to 2.4.2. ChangesGCS Storage Backend Support & APP_BASE_URL
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
charts/plane-enterprise/Chart.yaml (1)
8-8: ⚡ Quick winConsider a minor version bump instead of a patch version.
This PR adds GCS storage backend support with new configuration fields, which represents new functionality rather than a bug fix. According to semantic versioning conventions for Helm charts, feature additions typically warrant a minor version bump (e.g.,
2.5.0) rather than a patch bump (2.4.2). This helps users better understand the scope of changes when reviewing release notes.📋 Suggested version adjustment
-version: 2.4.2 +version: 2.5.0🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/plane-enterprise/Chart.yaml` at line 8, The Chart.yaml currently sets version: 2.4.2 (a patch bump) but you added new GCS storage backend functionality, so update the chart's semantic version to a minor bump (e.g., change version in Chart.yaml to 2.5.0) to reflect the new feature; locate the version field in Chart.yaml and replace the patch version with the new minor version, and ensure any release notes or CI/versioning metadata that reads Chart.yaml will pick up this change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/plane-enterprise/templates/config-secrets/doc-store.yaml`:
- Around line 26-27: Ensure MinIO-related flags are only enabled when storage is
S3: read the computed STORAGE_PROVIDER ({{ .Values.env.storage_provider |
default "s3" }}) and set USE_MINIO to "1" only if STORAGE_PROVIDER == "s3" and
services.minio.local_setup is truthy; otherwise set USE_MINIO to "0". Update the
doc-store template to compute STORAGE_PROVIDER once and gate USE_MINIO on that
value and on services.minio.local_setup so you cannot have STORAGE_PROVIDER
"gcs" while USE_MINIO remains enabled.
- Around line 28-31: When storage_provider is set to "gcs", fail fast by adding
a Helm conditional that checks .Values.storage_provider and uses the Helm
required function to validate GCS_CREDENTIALS_PATH (and/or
GCS_CREDENTIALS_JSON), GCS_BUCKET_NAME and GCS_PROJECT_ID before rendering;
modify the template around the GCS_* keys (GCS_BUCKET_NAME, GCS_PROJECT_ID,
GCS_CREDENTIALS_JSON, GCS_CREDENTIALS_PATH) to include something like an if
.Values.storage_provider == "gcs" ... required "error message"
.Values.env.gcs_credentials_path (and required checks for the bucket and
project) so deployment errors surface at helm render time rather than at
runtime.
---
Nitpick comments:
In `@charts/plane-enterprise/Chart.yaml`:
- Line 8: The Chart.yaml currently sets version: 2.4.2 (a patch bump) but you
added new GCS storage backend functionality, so update the chart's semantic
version to a minor bump (e.g., change version in Chart.yaml to 2.5.0) to reflect
the new feature; locate the version field in Chart.yaml and replace the patch
version with the new minor version, and ensure any release notes or
CI/versioning metadata that reads Chart.yaml will pick up this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d1bb532f-df1c-4f41-97b7-1aa051cec467
📒 Files selected for processing (3)
charts/plane-enterprise/Chart.yamlcharts/plane-enterprise/templates/config-secrets/doc-store.yamlcharts/plane-enterprise/values.yaml
2 participants
Summary by CodeRabbit
New Features
Chores