fix(desktop): 账号选择页支持访问全部身份 - #3323
Open
weikl666 wants to merge 1 commit into
Open
Conversation
Signed-off-by: weikl666 <126861179+weikl666@users.noreply.github.com>
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/components/login/LoginPage.tsx | 新增身份列表滚动视口、内容高度计算和滚动条提示;几何计算覆盖最后一项且保留原有前三项位置。 |
| apps/desktop/src/renderer/components/login/tests/LoginPage.pr2a.harness.test.tsx | 增加两项与五项身份场景,验证原坐标、滚动条件、提示调用和第四个企业身份选择。 |
| apps/desktop/src/renderer/components/login/loginDesignTokens.ts | 集中定义身份列表视口、行间距和底部留白常量,与面板及身份行尺寸一致。 |
Reviews (1): Last reviewed commit: "fix(desktop): make all login accounts re..." | Re-trigger Greptile
Contributor
|
这条 PR 需要维护者确认(product)。 登录身份选择页在超过 3 个身份时改为可滚动,并短暂显示滚动条提示——这是用户看得见的布局/交互变化,不是纯内部数据修复。 确认方式:请维护者直接在本 PR 上 Approve;若要改,请 Request Changes,作者改完后再 Approve。讨论见 #3336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这次改了什么
摘要
修复 Desktop 登录身份选择页在“个人身份 + 多个企业身份”时只能访问前三项的问题。
根因不是服务端少返回身份,而是登录面板固定高度并裁切溢出内容,第 4 项开始落在面板可视区域之外。现在标题区保持固定,身份卡片区域在超过 3 项时独立滚动,并在进入页面时短暂显示滚动条提示,避免用户不知道下方还有身份。
变更类型
feat新功能fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
UI 变化
docs/design-rules/DESIGN.md§16.2(几何常量集中管理,保留既有标题与前三项坐标)以及 Light / Dark 双模式交付约束(继续使用既有语义 token,无新增硬编码颜色)。怎么验证的
自动验证
手工验证
overflow-y: auto。XDS与最后一个企业身份可完整显示。XDS,成功进入客户端主界面。未执行的验证
风险
风险分类
影响与回滚
account-selection视图。提交前检查
git commit -s,见 DCO)