fix(desktop): 显示可读的本机设备名称 - #3312
Merged
Merged
Conversation
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/components/sidebar/MobileDownloadDialog.tsx | 从已规范化的设备快照读取本机名称并替代 UUID 展示,当前数据链路可保证名称具有非空回退值。 |
| apps/desktop/src/renderer/tests/mobileDownloadDialog.test.tsx | 测试模型及渲染断言已同步到新的设备名称展示行为。 |
| apps/desktop/src/renderer/i18n/locales/en/common.json | 英文翻译键及插值参数已与组件调用一致地更新。 |
| apps/desktop/src/renderer/i18n/locales/ja/common.json | 日文翻译键及插值参数已与组件调用一致地更新。 |
| apps/desktop/src/renderer/i18n/locales/ko/common.json | 韩文翻译键及插值参数已与组件调用一致地更新。 |
| apps/desktop/src/renderer/i18n/locales/zh-CN/common.json | 简体中文翻译键及插值参数已与组件调用一致地更新。 |
| apps/desktop/src/renderer/i18n/locales/zh-TW/common.json | 繁体中文翻译键及插值参数已与组件调用一致地更新。 |
Reviews (1): Last reviewed commit: "fix(desktop): 显示可读的本机设备名称" | Re-trigger Greptile
MagicLizi
approved these changes
Aug 24, 2026
MagicLizi
left a comment
Contributor
There was a problem hiding this comment.
按维护者指示批准;合并仍需通过 review-pr 的代码审查与其余安全门。
Contributor
|
合了。下载框里终于写的是人能认出来的本机名字,不用再对着一串 id 猜这是哪台电脑。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这次改了什么
摘要
下载手机版弹窗原来把本机内部
deviceId作为“本机 · …”展示,用户看到的是不可读的设备 UUID。现在改为复用远程连接设置页同一份设备列表中的可读self.name,并同步更新五种语言的 i18n key。变更类型
fix缺陷修复feat新功能refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
UI 变化
docs/design-rules/DESIGN.md§3 Typography Rules(等宽字体只用于代码内容,设备名使用普通 UI 字体);§4 Dialog & Modal(沿用现有弹窗容器与间距);§10 Light / Dark Dual-Mode Delivery Gate(继续使用语义颜色 token,亮色与暗色布局共用)。怎么验证的
自动验证
手工验证
未执行 Desktop 实机启动;已通过 jsdom 渲染测试覆盖设备名展示。
未执行的验证
未在 macOS / Windows 实机分别目检弹窗;改动只使用现有语义 token 与布局,不涉及平台特有代码。
风险
风险分类
影响与回滚
提交前检查
git commit -s,见 DCO)