feat(desktop): add archived task scope entry - #3294
Conversation
Signed-off-by: nothingyuancando <1579035512@qq.com>
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/features/cc-agent/sidebar/MachineSwitcherMenu.tsx | 新增归档范围入口，将归档筛选同步到菜单选中语义、段头文本和无障碍名称。 |
| apps/desktop/src/renderer/features/cc-agent/sidebar/MainListScopeHeader.tsx | 将现有侧栏 filter 传给 MachineSwitcherMenu，使入口与列表消费同一状态。 |
| apps/desktop/src/renderer/tests/machineSwitcherMenu.test.ts | 更新静态结构断言，并覆盖归档段头名称及 menuitem/aria-current 语义。 |
| apps/desktop/src/renderer/i18n/locales/en/common.json | 新增英文归档任务文案；其余四种桌面语言同步补齐对应键值。 |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
U[用户打开任务范围菜单] --> A[选择已归档任务]
A --> F[setStatus archived]
F --> L[会话列表按归档状态过滤]
F --> H[段头显示归档状态]
H --> M[菜单项通过 aria-current 表示当前范围]
Reviews (7): Last reviewed commit: "fix(desktop): expose archived scope as c..." | Re-trigger Greptile
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 443c0b949f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: nothingyuancando <1579035512@qq.com>
|
已修复 CI 契约失败并推送 commit |
|
@nothingyuancando 👋 这个 PR 还有 1 条 review conversation 没 resolve(apps/desktop/src/renderer/features/cc-agent/sidebar/MainListScopeHeader.tsx),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
|
这个 PR 改了用户看得见的侧栏范围菜单（新增「已归档任务」入口和选中态），已提交维护者确认，讨论见 #3297。 请维护者直接在本 PR 上 Approve；若要改，请 Request Changes。作者这边先不用再推代码等确认结果。 |
|
命中 UI 路径(apps/desktop/src/renderer/features/cc-agent/sidebar/MachineSwitcherMenu.tsx / apps/desktop/src/renderer/features/cc-agent/sidebar/MainListScopeHeader.tsx)但 description 未附界面效果证据——建议补充改动后效果:截图/录屏,或改动后界面的 HTML 页面(```html 代码块、.html 附件或在线预览链接),便于确认界面符合 DESIGN.md 设计规范 |
|
已处理并推送：
本地环境缺少完整 workspace 内部包，无法运行该 worktree 的 device-link 测试；失败日志已按 Windows CI 的真实失败断言修正。请 CI 重新运行。 |
Signed-off-by: nothingyuancando <1579035512@qq.com>
68ff763 to
991ae51
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 991ae51e4a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: nothingyuancando <1579035512@qq.com>
|
已处理最新 P2 review：归档范围现在同步加入 commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 465b5de8a3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: nothingyuancando <1579035512@qq.com>
|
已处理新 P2 无障碍 review：归档菜单项现在使用 |
|
已按 UI review 建议更新 PR description，新增“改动后界面效果证据”HTML 代码块，覆盖范围按钮、一级归档菜单项、选中态、aria-label/aria-checked，以及远程设置入口，便于按 DESIGN.md 核对。 |
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6075aed08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
3 participants
这次改了什么
在“全部任务”范围菜单中新增一级“已归档任务”入口，复用现有
useSidebarFilter的setStatus('archived')；进入归档视图后，段头持续显示归档状态，菜单项显示选中态。五种桌面语言均已补齐。关联 Issue：#3214
明确不包含：新的归档数据模型、IPC、查询接口或第二套筛选状态。
UI 变化
docs/design-rules/DESIGN.md§1 Visual Theme & Atmosphere、§2 Color Palette & Roles、§4 Component Stylings；复用现有菜单结构、语义主题 token、图标与选中态，不新增装饰性视觉层。怎么验证的
自动验证
node scripts/check-i18n.mjs：通过（仅仓库既有警告）。node scripts/check-i18n-glossary.mjs：通过（仅仓库既有 proposed 术语警告）。git diff --check：通过。pnpm test:unit:related：已启动，但新 worktree 缺少完整 workspace 依赖，Desktop 测试收集阶段因缺失@cindy/maker-shared/*、@cindy/voice-input-core等内部包失败；未出现本次改动断言失败。手工验证
未执行：当前环境没有可运行的 Desktop 实例；交互由现有 Radix 菜单和筛选状态路径承载。
风险
风险分类
影响与回滚
影响范围：Desktop 侧栏归档入口与本地化文案。回滚方式：撤销本 PR commit；不涉及数据迁移、协议、权限或跨平台原生行为。
提交前检查
改动后界面效果证据
以下 HTML 反映改动后的实际结构与状态（对应
MachineSwitcherMenu/MainListScopeHeader；颜色由现有主题 token 提供）：验收重点：归档入口位于范围菜单一级；归档状态在段头持续可见；选中态同时由勾选图标和
aria-checked表达；菜单继续复用现有 Radix 结构、间距和主题 token，无新增装饰层。