Fix: 'NoneType' crash in get_project_mag_ratios_from_response on wallet v5.5.0#66
Merged
makeasnek merged 1 commit intoJun 8, 2026
Conversation
…RL unresolvable Claude Sonnet 4.6 assisted me with resolving this issue and submitting my first PR ever. Verify my changes before submitting please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
Environment
Bug
FTM crashes with
'NoneType' object has no attribute 'upper'when fetching mag ratios from the wallet at startup. Falls back to web, crashes there too. BOINC control still runs but all mag ratios are zero.Root cause
get_project_mag_ratios_from_response()callsgrc_project_name_to_url()for each project incontract_contents.projects. When that returnsNone(unresolvable project name), it flows unchecked intoresolve_url_database(), which calls.upper()unconditionally on line 155.Fix
Added
Noneguard beforeresolve_url_database()call. Unresolvable projects are logged at DEBUG and skipped.Tested on
wallet v5.5.0.0-5 — mag ratios now fetch successfully from wallet at startup.