Skip to content

Feature/216 UI fixes #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitguptaindia merged 2 commits into from
May 22, 2026
+15 −7
Merged

Feature/216 UI fixes #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c61f3
Fix calendar icon and date picker
alaca May 18, 2026
9d24307
Ad LRI chars
alaca May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion assets/css/analytics.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@ body.mailchimp_page_mailchimp_sf_analytics {
padding: 0 10px;
width: 36px;
border-inline-start: 1px solid #c3ced5; /* visual separator between text and icon */

svg {
display: block;
fill: #50575e;
height: 18px;
width: 18px;
}
}

#mailchimp-sf-date-picker-label {
Expand Down Expand Up @@ -205,6 +212,7 @@ body.mailchimp_page_mailchimp_sf_analytics {
}

.mailchimp-sf-date-picker-input-wrap input[type="text"] {
padding-inline-start: 8px;
padding-inline-end: 30px; /* RTL-aware: leave room for the calendar icon */
Comment thread
iamdharmesh marked this conversation as resolved.
}
}
Expand Down Expand Up @@ -1027,7 +1035,7 @@ body.mailchimp_page_mailchimp_sf_analytics {

[dir="rtl"] #mailchimp-sf-settings-page .mailchimp-sf-date-picker-field .mailchimp-sf-date-picker-input-wrap input[type="text"] {
padding-left: 30px;
padding-right: 0;
padding-right: 8px;
}

@media screen and (max-width: 782px) {
Expand Down
12 changes: 6 additions & 6 deletions assets/js/analytics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,9 +505,9 @@ import { __ } from '@wordpress/i18n';
day: 'numeric',
year: 'numeric',
});
return `${fmt.format(fromDate)} – ${fmt.format(toDate)}`;
return `\u2066${fmt.format(fromDate)} – ${fmt.format(toDate)}\u2069`;
} catch (err) {
return `${from} – ${to}`;
return `\u2066${from} – ${to}\u2069`;
Comment thread
iamdharmesh marked this conversation as resolved.
}
}

Expand Down Expand Up @@ -948,9 +948,9 @@ import { __ } from '@wordpress/i18n';
day: 'numeric',
year: 'numeric',
});
return `${fmt.format(fromDate)} – ${fmt.format(toDate)}`;
return `\u2066${fmt.format(fromDate)} – ${fmt.format(toDate)}\u2069`;
} catch (err) {
return `${from} – ${to}`;
return `\u2066${from} – ${to}\u2069`;
}
}

Expand Down Expand Up @@ -1326,9 +1326,9 @@ import { __ } from '@wordpress/i18n';
day: 'numeric',
year: 'numeric',
});
return `${fmt.format(fromDate)} – ${fmt.format(toDate)}`;
return `\u2066${fmt.format(fromDate)} – ${fmt.format(toDate)}\u2069`;
} catch (err) {
return `${from} – ${to}`;
return `\u2066${from} – ${to}\u2069`;
}
}

Expand Down