Repository navigation
workbuddy: omit unsupported REA surrogate guard from tool schemas - #1080
Merged
yetone merged 1 commit intoNov 13, 2026
Merged
Conversation
zhbcn
force-pushed
the
fix/workbuddy-rea-surrogate-pattern
branch
from
November 13, 2026 07:22
ebf4e93 to
2f4738e
Compare
Contributor
|
Thanks @zhbcn, this is small and well scoped. Reviewed at 2f4738e:
One note, no change needed: this applies to every WorkBuddy model, not only DeepSeek. That's fine, since the guard only rules out lone surrogates in a path, and REA still checks it server-side. I'll merge it on the next pass (we don't merge in the same pass as a push). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkBuddy AI's
deepseek-v4.1-flash-sgrejects a fresh DeepSeek Harness request with400: WorkBuddy AI: invalid function call parameterswhen the advertised tools include REA's exact^[^\uD800-\uDFFF]*$path guard. This fails before generation, even when the user does not call a tool.Omit only this exact pattern in the existing recursive outbound schema normalization. Keep the surrounding
allOf, NUL/absolute-path constraints, other patterns, and the tool server's own validation. Add regressions covering nested properties, array items and$defs, unchanged source input, idempotence, and preservation of other surrogate patterns. Bump WorkBuddy to 0.2.34.Validation:
bun scripts/check.mjs workbuddyandgit diff --checkpass.binary_sessionalone fails. Its NUL and absolute-path patterns each succeed individually; the surrogate guard alone reproduces the 400.fitted()to the original 299-tool catalog removes 15 guards across 14 tools: the same WorkBuddy AI DeepSeek route returns HTTP 200, both for a short reply and a validbinary_session({detail: "summary"})tool call. No returned tool call was executed.This addresses schema rejection. It does not claim to fix the separate GLM incident where generated tool arguments repeated until the output token limit.