Skip to content

nowledge-mem: allow slow Chrome starts in CI - #1076

Merged
yetone merged 1 commit into
magpie-community:mainfrom
yetihan:codex/fix-nowledge-layout-ci-timeout
Nov 13, 2026
Merged

yetone merged 1 commit into
magpie-community:mainfrom
yetihan:codex/fix-nowledge-layout-ci-timeout

Conversation

@yetihan

@yetihan yetihan commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #1071.

Root cause

The layout test already stops Chrome and reports its stderr when it produces no DOM, but its 25-second launch bound is also used during the full CI test suite. Under runner load, Chrome can start after that bound even though the page and layout assertions are healthy, so the test kills a merely slow launch and blocks the publish workflow.

Fix

  • Keep the 25-second launch bound for fast local feedback.
  • Allow up to 90 seconds when CI is set.
  • Derive the Bun test timeout from the launch bound with another 10 seconds for process-group shutdown, stderr collection, and temporary-directory cleanup.

The Chrome flags, process-group cleanup, failure diagnostics, layout cases, and assertions are unchanged.

Verification

  • Linux arm64, Bun 1.4.4, deterministic fake Chrome that emits 30 valid layout rows after 26 seconds:
    • Baseline d24fd5d: fails at 25,072.89 ms with Chrome gave no results within 25000ms.
    • This change with CI=1: passes at 26,022.94 ms and executes 62 expectations.
  • bun test packages/nowledge-mem — 161 pass, 2 skip, 0 fail on macOS; the Linux-only Chrome test is skipped there.
  • bun scripts/check.mjs — pass.
  • git diff --check — pass.

@yetone
yetone merged commit 6059fb1 into magpie-community:main Nov 13, 2026
2 checks passed
@yetone

yetone commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Thanks @yetihan, merged. Ran bun test packages/nowledge-mem with CI=1 on Linux (no Chrome there, so the layout test itself skipped); the merge's CI run is the real-Chrome check. I'll close #1071 once that run is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nowledge-mem: 'narrow settings footer keeps translated actions inside the dialog' times out at 25s on CI again (after #972)

2 participants