Repository navigation
nowledge-mem: allow slow Chrome starts in CI - #1076
Merged
yetone merged 1 commit intoNov 13, 2026
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1071.
Root cause
The layout test already stops Chrome and reports its stderr when it produces no DOM, but its 25-second launch bound is also used during the full CI test suite. Under runner load, Chrome can start after that bound even though the page and layout assertions are healthy, so the test kills a merely slow launch and blocks the publish workflow.
Fix
CIis set.The Chrome flags, process-group cleanup, failure diagnostics, layout cases, and assertions are unchanged.
Verification
d24fd5d: fails at 25,072.89 ms withChrome gave no results within 25000ms.CI=1: passes at 26,022.94 ms and executes 62 expectations.bun test packages/nowledge-mem— 161 pass, 2 skip, 0 fail on macOS; the Linux-only Chrome test is skipped there.bun scripts/check.mjs— pass.git diff --check— pass.