Test minimal versions in CI with a pinned lockfile#33
Closed
ijackson wants to merge 4 commits into
Closed
Conversation
4.2.0 does not build, because num-bigint doesn't:
Compiling num-bigint v0.4.0
error[E0308]: mismatched types
--> /home/rustcargo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/num-bigint-0.4.0/src/biguint/convert.rs:70:19
|
70 | .div_ceil(&big_digit::BITS.into())
| -------- ^^^^^^^^^^^^^^^^^^^^^^^ expected `u64`, found `&_`
| |
| arguments to this method are incorrect
|
= note: expected type `u64`
found reference `&_`
Contributor
Author
Contributor
Author
|
(Also, if you like this, I could make a similar MR against |
Owner
|
Thanks for the PR. I understand the idea, but my projects usually do not use pinned lockfiles for this kind of CI setup. I prefer to keep the normal dependency resolution, so I can quickly notice what happens when newer versions are picked up. So I do not plan to merge this PR at the moment. I still appreciate your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this MR, we:
Cargo.tomldo work