fix: avoid argument limit in webauthn base64url encoding#1095
Open
samsamtrum wants to merge 1 commit into
Open
fix: avoid argument limit in webauthn base64url encoding#1095samsamtrum wants to merge 1 commit into
samsamtrum wants to merge 1 commit into
Conversation
samsamtrum
force-pushed
the
fix-webauthn-large-base64url
branch
from
ce59f7b to
6835cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebAuthn Base64URL encoder currently spreads the full byte array into String.fromCharCode. Large buffers can exceed the JavaScript argument limit and throw a RangeError before encoding.
This keeps the same byte-to-string conversion, but processes the input in bounded chunks before calling btoa. That avoids passing the entire buffer as function arguments at once while preserving the encoded output.
Verified with a local Node check:
I also tried a direct TypeScript check for this file, but the partial dependency install in this workspace is missing several type packages, so that command fails in node_modules type resolution before validating this file.