Skip to content

chore(deps): update engine to the account-store and prepare fix stack - #1607

Draft
Dodecahedr0x wants to merge 1 commit into
devfrom
dode/engine-fix-stack-dep
Draft

chore(deps): update engine to the account-store and prepare fix stack#1607
Dodecahedr0x wants to merge 1 commit into
devfrom
dode/engine-fix-stack-dep

Conversation

@Dodecahedr0x

@Dodecahedr0x Dodecahedr0x commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What changed

Pins every magicblock-engine git dependency and [patch.crates-io] entry to rev ec741da47eca2f43f5797dde2530640ecb12aa39, the tip of the engine fix stack (magicblock-labs/magicblock-engine#103, magicblock-labs/magicblock-engine#104, magicblock-labs/magicblock-engine#105), instead of tag 0.3.1. Adds magic-root-interface to the workspace dependency table (used later in this stack) and regenerates Cargo.lock. The dependency-table reformatting is from the workspace TOML formatter.

Closes #1598

Impact

The validator picks up in-place account slot reuse, the Prepare instruction for missing writable action accounts, and the checksum-boundary index fsync. No validator code changes. The rev pin is a stopgap until the engine stack lands in a release tag.

Reviewer notes

The rev must stay reachable on the engine remote (it is the head of the dode/sync-on-checksum PR branch). cargo check --workspace passes at this commit against the pinned rev.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Dodecahedr0x Dodecahedr0x self-assigned this Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b391c1ec-f6b5-4b5e-a11b-23ec23aa2ec1

📥 Commits

Reviewing files that changed from the base of the PR and between 241c3f6 and f55465b.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Workspace dependency update

Layer / File(s) Summary
Workspace manifest organization
Cargo.toml
The workspace adds storage-proto. Dependency feature lists and related declarations are reformatted without changing most values.
MagicBlock Engine revision pinning
Cargo.toml
MagicBlock Engine dependencies and patched Agave and Solana crates use revision ec741da47eca2f43f5797dde2530640ecb12aa39. The manifest adds magic-root-interface.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f5546

The PR updates pinned engine dependencies and the lockfile while preserving the documented workspace behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: bmuddha, gabrielepicco, snawaz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the dependency update to the account-store engine and preparation of the fix stack.
Description check ✅ Passed The description directly explains the pinned engine revision, added dependency, regenerated lockfile, expected validator impact, and temporary nature of the revision pin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dode/engine-fix-stack-dep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the engine dependency to the account-store and prepare fix stack

1 participant