fix: use wire size (1232), not encoded size (1644), for tx fit checks!

[snawaz]

• Use the serialized transaction wire size for committor fit checks because Solana sendability is capped by PACKET_DATA_SIZE (1232 bytes), not the RPC base64 string limit (1644).

• bug: the old encoded-length check was imprecise: raw sizes like 1231, 1232, and 1233 all encode to 1644 bytes, so we could accept a 1233-byte transaction that cannot be sent.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR replaces base64-encoded transaction size checks with serialized wire-size checks. It adds MAX_TRANSACTION_WIRE_SIZE derived from solana_packet::PACKET_DATA_SIZE, a serialized_transaction_size helper using bincode, updates packing constants (process-and-close 5→4, undelegate 16→15), switches all size comparisons in task strategist and transaction helpers to use wire-size, updates tests to measure wire-size, and adds solana-packet to workspace/crate dependencies while removing base64 from the crate dependencies.

Suggested reviewers

• GabrielePicco
• thlorenz
• taco-paco

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch snawaz/fix-tx-size

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[snawaz]

• fix: use wire size (1232), not encoded size (1644), for tx fit checks! #1285 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@magicblock-committor-service/src/transactions.rs`:
- Around line 86-91: The function serialized_transaction_size currently calls
bincode::serialized_size(transaction).unwrap() and
usize::try_from(...).unwrap(), which can panic; change the API to return a
Result<usize, E> (e.g., Result<usize, anyhow::Error> or a crate-specific error)
so callers handle serialization failures and width-conversion failures. Inside
serialized_transaction_size (and when referencing SerializableTransaction), call
bincode::serialized_size(transaction) and propagate errors (map bincode::Error
to your error type), then convert the u64 size to usize using
usize::try_from(size).map_err(...) and return that Result instead of unwrapping.
Update any callers to handle the Result accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7c024429-37b3-4665-9871-7366755cc779

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee6832 and 1af9f16.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

• Cargo.toml
• magicblock-committor-service/Cargo.toml
• magicblock-committor-service/src/tasks/mod.rs
• magicblock-committor-service/src/tasks/task_strategist.rs
• magicblock-committor-service/src/transactions.rs

[coderabbitai]

♻️ Duplicate comments (1)

magicblock-committor-service/src/transactions.rs (1)

69-74: ⚠️ Potential issue | 🟠 Major

Remove the panic path from serialized_transaction_size.

This helper still has two .unwrap() calls in production code, so a serialization failure here aborts sizing/strategy selection instead of surfacing an error to callers that enforce MAX_TRANSACTION_WIRE_SIZE.

As per coding guidelines: "Treat any usage of .unwrap() or .expect() in production Rust code as a MAJOR issue."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@magicblock-committor-service/src/transactions.rs` around lines 69 - 74,
serialized_transaction_size currently panics via two .unwrap() calls; change its
signature from fn serialized_transaction_size(transaction: &impl
SerializableTransaction) -> usize to return a Result<usize, Box<dyn
std::error::Error + Send + Sync>> (or a concrete error type used in the crate),
then propagate errors instead of unwrapping: call
bincode::serialized_size(transaction)? to get the u64 and convert it with
usize::try_from(...)? (or .try_into()?) and map/propagate the TryFromIntError so
callers can handle serialization/size failures; keep the function name
serialized_transaction_size and the SerializableTransaction trait reference so
the change is localized.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@magicblock-committor-service/src/transactions.rs`:
- Around line 69-74: serialized_transaction_size currently panics via two
.unwrap() calls; change its signature from fn
serialized_transaction_size(transaction: &impl SerializableTransaction) -> usize
to return a Result<usize, Box<dyn std::error::Error + Send + Sync>> (or a
concrete error type used in the crate), then propagate errors instead of
unwrapping: call bincode::serialized_size(transaction)? to get the u64 and
convert it with usize::try_from(...)? (or .try_into()?) and map/propagate the
TryFromIntError so callers can handle serialization/size failures; keep the
function name serialized_transaction_size and the SerializableTransaction trait
reference so the change is localized.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4245a7ca-d273-4629-9922-dc0069eb8960

📥 Commits

Reviewing files that changed from the base of the PR and between 1af9f16 and 6aa1294.

⛔ Files ignored due to path filters (2)

• Cargo.lock is excluded by !**/*.lock
• test-integration/Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• magicblock-committor-service/Cargo.toml
• magicblock-committor-service/src/transactions.rs
• test-integration/test-committor-service/tests/test_ix_commit_local.rs

💤 Files with no reviewable changes (1)

• magicblock-committor-service/Cargo.toml

[taco-paco]

LGTM