feat: snapshot accountsdb even in the replica mode

[bmuddha]

Summary by CodeRabbit

• Bug Fixes

  • Refined replica-mode handling to avoid superblock replication being broadcast incorrectly
  • Improved lifecycle of database pause permits during replica block application to ensure correct notifications

• Tests

  • Added integration test verifying replica-mode snapshot behavior without publishing superblock messages
  • Added configurable replica-mode test environment to support superblock-size scenarios

[coderabbitai]

Warning

Review limit reached

@bmuddha, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 39 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 30107c2f-3f3e-4913-8929-e54f68eacfd5

📥 Commits

Reviewing files that changed from the base of the PR and between ddc8540 and 2515fc8.

📒 Files selected for processing (1)

• magicblock-processor/src/scheduler/mod.rs

📝 Walkthrough

Walkthrough

This PR modifies the scheduler to gate superblock replication messages to primary mode only, while adding superblock handling at two new trigger points in replica mode: after slot transitions on incoming blocks and after successful executor notification during block replays. The replica block replay path now explicitly manages the exclusive DB-access permit by retaining it during executor notification and then dropping it before calling superblock handling. Test infrastructure is extended to support custom superblock sizes, enabling an integration test that validates replica mode does not publish superblock messages while still creating accountsdb snapshots at superblock boundaries.

Suggested reviewers

• GabrielePicco
• taco-paco
• lucacillario

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bmuddha/feat/always-snapshot-accountsdb

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@magicblock-processor/src/scheduler/mod.rs`:
- Around line 273-275: The code calls handle_superblock for the same slot twice:
once via the block_produced.recv() branch after apply_replayed_block() updates
latest_block, and again after transition_to_new_slot() in the replay path.
Remove or guard the redundant handle_superblock call in the replay path (the
second invocation after transition_to_new_slot) so that handle_superblock is
only invoked by the block_produced.recv() branch; alternatively, add a simple
check (e.g., compare the slot returned by transition_to_new_slot or inspect
latest_block) before calling handle_superblock to avoid duplicate handling.
Ensure changes reference apply_replayed_block, transition_to_new_slot, and
handle_superblock.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3658830c-2b90-485e-8d38-e9fd1bcff407

📥 Commits

Reviewing files that changed from the base of the PR and between ab56862 and 372e576.

📒 Files selected for processing (3)

• magicblock-processor/src/scheduler/mod.rs
• magicblock-processor/tests/replica_ordering.rs
• test-kit/src/lib.rs

[lucacillario]

LGTM