deps: bump react-router-dom from 7.18.2 to 7.18.4 in /frontend - #58
Merged
magicapple123 merged 1 commit intoOct 2, 2026
Merged
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
magicapple123
added a commit
that referenced
this pull request
Oct 2, 2026
WebFormPage「跨页返回恢复未完成会话」用例在 CI 上偶发失败 （#58 的 Frontend 作业）： TestingLibraryElementError: Unable to find an accessible element with the role "button" and name /结束本次填写/ 根因是测试自身的时序竞态，而非 router 7.18.4 的行为变化： - 「结束本次填写」按钮的渲染门控是 `running && (sessionActive || live?.running)` （WebFormPage.tsx），除了 sessionStorage 的会话恢复外，还依赖 getWebFormBrowserStatus 轮询返回的 running —— 它与「填充到页面」按钮 不在同一次状态提交里。 - 原断言在 waitFor「填充到页面」出现后**同步** getByRole「结束本次填写」， 高负载下后者尚未提交即抛错。 - 佐证：router 7.18.3/7.18.4 changelog 无会话恢复相关变更 （7.18.4 仅 RSC redirect 转义与 #15485 避免 startViewTransition 的时序 变化）；本地 7.18.4 下单文件 15 连跑 + 全量套件均绿，失败只在 CI 负载下偶发，与 #60 的 useWatch 竞态同类。 修复：两处同步断言改为 findByRole / findByDisplayValue 等待落地， 断言内容（role / name / 值）不变，无放松。 验证：vitest 801/801（123 文件）；eslint 0 error / 11 warning（基线）； tsc --noEmit、prettier --check 通过。
magicapple123
added a commit
that referenced
this pull request
Oct 2, 2026
react-router-dom 7.18.4 timing exposes the same class of CI-only race as #60: the "结束本次填写" button renders in a later state commit than the "填充到页面" wait covered (depends on browser-status polling). Two synchronous assertions became findBy* waits — assertion values unchanged. 15 consecutive local runs green on 7.18.4. Fixes the #58 Frontend flake.
Owner
|
@dependabot rebase |
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 7.18.2 to 7.18.4. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/react-router-dom@7.18.4/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@7.18.4/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-version: 7.18.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/frontend/react-router-dom-7.18.4
branch
from
October 2, 2026 12:51
d799465 to
ad1fa23
Compare
dependabot
Bot
deleted the
dependabot/npm_and_yarn/frontend/react-router-dom-7.18.4
branch
October 2, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-router-dom from 7.18.2 to 7.18.4.
Changelog
Sourced from react-router-dom's changelog.
Commits
1b1e0b0Release v7.18.4 (#15498)23166dfRelease v7.18.3 (#15424)