ci: ignore react/react-dom major updates until antd 6 migration - #30
Closed
magicapple123 wants to merge 1 commit into
Closed
magicapple123 wants to merge 1 commit into
magicapple123 wants to merge 1 commit into
Conversation
antd 5 peer-locks react to ^16||^17||^18, so dependabot major bumps to react 19 fail npm ci with ERESOLVE (same failure mode as PR #21 where only half of a peer-locked pair was bumped). Ignore majors for react and react-dom together - react-dom must always follow react's major. Remove this block once the antd 6 migration lands.
Owner
Author
|
Superseded by #28, which is already merged to main with the same ignore block (react + react-dom + @types/react + @types/react-dom >=19, with a TODO comment tied to the antd 6 migration). Good catch on react-dom needing to be ignored together with react — #28 covers it. Closing as duplicate; nothing to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
dependabot.yml 的 npm 段新增 ignore：react 与 react-dom 的 semver-major 更新，附 TODO(antd-6-migration) 注释。
理由
antd 5 的 peer 依赖锁定 react ^16||^17||^18，dependabot 若开 react 19 主版本 PR 会直接 ERESOLVE 挂死 npm ci——与 #21（只升 vitest 不升 @vitest/coverage-v8）、#17（fpdf2 行为变化）是同一类「只动一半就撞 peer/行为墙」的坑。react-dom 必须与 react 同 major，因此两者一起 ignore。
fpdf2 说明
按任务讨论评估过给 fpdf2 加 ignore，但 #29 已把 fpdf2 升到 2.8.9 且 CI 全绿（行为变化已用最小修复消化），无需 ignore，未来小版本照常跟进。
生效方式
merge 后 dependabot 下次配置读取时生效（无需等周一计划任务，config change 会触发重新配置）。