Remove VLAs - #246
Merged
Merged
Conversation
Part of #239.
Part of #239.
Part of #239.
Part of #239.
Part of #239.
Reuse a single xwcsbuf_T for the pattern components instead of allocating a variable-length array on the stack in each iteration. Part of #239.
Part of #239.
The mbsargv array is now allocated on the heap with xmalloce. If execve succeeds, the memory is discarded by exec; on the failure path it is freed before returning. Part of #239.
Part of #239.
The extended_count workaround for empty variable-length arrays is no longer needed now that the array is allocated on the heap. Part of #239.
The extended_count workaround for empty variable-length arrays is no longer needed now that the array is allocated on the heap. Part of #239.
A single xstrbuf_T allocated outside the loop is now reused to build the candidate pathnames. Part of #239.
The count is clamped to a constant bound, so a fixed-size buffer suffices. The bound is now a named constant. Part of #239.
This prevents variable-length arrays from creeping back into the codebase. Closes #239.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #239