Substitute empty match in ${var/foo/bar} - #244
Merged
Merged
Conversation
The xfnm_subst function performed substitution of an empty match only
when XFNM_HEADTAIL was set, which was not consistent with the behavior
for other flags. This commit changes the function to always substitute
an empty match like any other match, and when substituting all matches,
one character is skipped after each empty match to ensure progress. This
allows `${var/#/prefix}` and `${var/%/suffix}` to prefix and suffix the
value, respectively.
magicant
force-pushed
the
matching-empty-string
branch
from
July 28, 2026 13:30
aba17fd to
2759232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xfnm_subst function performed substitution of an empty match only when XFNM_HEADTAIL was set, which was not consistent with the behavior for other flags. This commit changes the function to always substitute an empty match like any other match, and when substituting all matches, one character is skipped after each empty match to ensure progress. This allows
${var/#/prefix}and${var/%/suffix}to prefix and suffix the value, respectively.Fixes #243