Repository navigation
Improve DVD encoding, playback, file handling and queue controls - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, fixes #2, fixes #3, fixes #5, fixes #6.
This preview fixes folder/file handling and adds configurable playback and FFmpeg encoding profiles. Scans ignore macOS metadata sidecars; excluding failed files makes otherwise valid jobs runnable. File drops retain exact selections and can group videos into one DVD set. Job and file lists share Explorer-style click/Ctrl/Shift selection, Select all, and bulk actions. Selected active jobs can be stopped/removed without removing unrelated jobs or source/output files. Job tiles and the footer show progress; the compact header exposes source/output information and Job settings.
Default settings apply to future jobs; each job keeps independent overrides. Balanced/Quality and playback choices are in Job settings. Single-video jobs default to automatic playback without menus; multi-video jobs default to menus. Either can be overridden. Menu-free discs play all included titles in order across aspect-specific titlesets, then stop. Explicit playback choices survive rescans and inclusion changes. Menu editing disables immediately for menu-free jobs.
FFmpeg is the sole external video encoder. Balanced is the default: two-pass 7.5 Mbps target / 9 Mbps peak, RD macroblock decisions, intra VLC, quantizer floor 2, and 256 kbps stereo AC-3. Quality retains the 9 Mbps target/peak, finer quantization, trellis, detailed motion analysis and 448 kbps audio. Profile-specific cache keys and estimates preserve legacy Quality encodes and prevent incompatible reuse. Packing adds discs instead of lowering the chosen profile's bitrate. Repeated 60-second tests measured 2.96 s for Balanced versus 12.47 s for Quality, with 20% less video data.
Pillarbox detection checks every frame and retains the union of visible picture pixels. Small 4:3-boundary variations expand the kept picture instead of rejecting cropping; wider content and tiny marks deeper in a border still prevent cropping. Corrected MPG/DVD streams report 4:3. Scope sources retain full-width content inside the compliant letterboxed 16:9 DVD frame; screenshot measurements explain side margins in wider playback windows. Unicode authoring folders use temporary ASCII aliases that preserve relative paths.
Validation: all-package tests/vet and headless CI-tag checks; backend race checks; actual PAL/NTSC pipelines for both profiles; interlace/cadence/audio/profile constraints; Unicode paths; resume/publication recovery; menus/autoplay; 36/99-title authoring; full real-media encodes/decode/hash checks. A fresh libVLC check observed automatic titles 1 → 2 → 3 and playback ending without a menu. Physical-player, clean-VM and full-capacity DVD-9/layer-break testing remain open. Version is 0.1.0-preview.9.
Details: playback/UI validation, profiles and Scope measurements, encoding guide.