Skip to content

Gamma/Brightness filter#67

Open
accraze wants to merge 5 commits into
mafintosh:masterfrom
accraze:gamma-filter
Open

Gamma/Brightness filter#67
accraze wants to merge 5 commits into
mafintosh:masterfrom
accraze:gamma-filter

Conversation

@accraze

@accraze accraze commented Dec 13, 2015

Copy link
Copy Markdown

This PR is in reference to #8 video effects using css filters.

Two new things added:
  • Settings control/popup for video playback (this only appears when a video is playing)
  • Brightness filter for video (inside Settings popup)

gamma/brightness css filter has been added for videos. when a video plays a new settings control appears on the right hand side. this new popupcontains a range input that changes the video's brightness.
@max-mapper

Copy link
Copy Markdown
Collaborator

nice!

screen shot 2015-12-14 at 11 14 30 am

screenshot was hard to get so its half faded out

the font size in the settings menu looks a little big compared to the rest of the fonts, but otherwise i'm +1. lays some nice groundwork for other settings

@mafintosh

Copy link
Copy Markdown
Owner

i agree with @maxogden on the font. looking good otherwise!

@zeke

zeke commented Dec 14, 2015

Copy link
Copy Markdown

What are you watching, @maxogden?

@max-mapper

Copy link
Copy Markdown
Collaborator

iron chef america thanksgiving battle

@zeke

zeke commented Dec 14, 2015

Copy link
Copy Markdown

lol

@freeall

freeall commented Dec 14, 2015

Copy link
Copy Markdown
Collaborator

@maxogden not sure if it helps you in this case, but hitting space when taking a screenshot on osx selects the current window so you don't have to drag.

@accraze

accraze commented Dec 17, 2015

Copy link
Copy Markdown
Author

Thanks for the feedback guys! I resized the label down to 15px
... let me know if you think it should be a different size..

screenshot_converted

@mafintosh

Copy link
Copy Markdown
Owner

@accraze label size looks good now. i wonder if we could use the same slider as we use for volume control to have consistent ui across the app

@bmathews

Copy link
Copy Markdown
Collaborator

@mafintosh Just a heads up, I've been doing some experiments with refactoring and separating out the UI from the rest of the player/server code. It'll be another week or two until it's all finished though.

@mafintosh

Copy link
Copy Markdown
Owner

@bmathews oh sweet!

@accraze

accraze commented Dec 27, 2015

Copy link
Copy Markdown
Author

@mafintosh added the same slider to the brightness filter... lemme know if anything else needs changing
slider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants