Fixing typos - #2055
Open
brianveldman wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughCorrects typos and wording across Safe Documents results, PowerShell help and messages, remediation guidance, generated reports, current and versioned documentation, blog content, and comments. No executable logic, public interfaces, or JSON structure changes. ChangesEditorial corrections
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.45.0)powershell/assets/ReportTemplate.htmlast-grep timed out on this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build/aitools/test-metadata/test-results.json`:
- Line 13416: Correct the remaining ORCA.234 source typos in the
check-ORCA234.ps1 description, changing “Pretected View” to “Protected View” and
“usres” to “users.” Then regenerate test-results.json so the generated metadata
reflects the corrected source text.
In `@powershell/assets/ReportTemplate.html`:
- Line 16286: Update the Safe Documents description in the ORCA.234 test result
to change “allow users click through Protected View” to “allow users to click
through Protected View,” preserving the surrounding text.
In `@powershell/internal/orca/check-ORCA234.ps1`:
- Line 37: Update the ORCA234 source definition in the source repository’s
check-ORCA234.ps1: correct “allow users click through” to “allow users to click
through,” fix “Pretected View” to “Protected View,” and clean up the “usres”
typo in $this.FailRecommendation. Regenerate the generated ORCA234 files from
the corrected source so all copies match.
In `@powershell/public/orca/Test-ORCA234.md`:
- Line 1: Correct the wording in Test-ORCA234’s description by changing
“Pretected View” to “Protected View” and revising “allow users click through” to
“allow users to click through.”
In `@report/src/lib/testResults.ts`:
- Line 18893: Correct the synchronized Safe Documents descriptions in
report/src/lib/testResults.ts at lines 18893-18893 and 19693-19693: change “can
assist protecting” to “can assist in protecting” in both entries, and
additionally correct “Pretected,” “usres,” and “allow users click through” in
the latter entry.
- Around line 7905-7908: Update the MT.1074 TestTitle and TestResult text to
correct “then” to “than” and “send” to “sent,” and use the same threshold
wording as TestDescription, preferably “no more than 100” if the limit is
inclusive. Keep the entry’s meaning and surrounding description unchanged.
In `@website/blog/2025-08-16-compensating-controls/index.md`:
- Line 45: Update the paragraph’s grammar by changing “consensus driven” to
“consensus-driven,” rewriting the sentence beginning “An example being” as a
complete sentence, and converting the fragment beginning “Where external
standards” into a complete sentence while preserving the existing meaning.
In `@website/docs/sections/create-entra-app.md`:
- Line 74: Update the introductory documentation sentence to use the standard
hyphenated phrase “Azure Role-Based Access Control (RBAC) implementation,”
leaving the surrounding wording unchanged.
In `@website/docs/tests/orca/ORCA.234.md`:
- Line 25: Correct the typo “Pretected View” to “Protected View” in both
ORCA.234 pages: website/docs/tests/orca/ORCA.234.md at lines 25-25 and
website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md at lines 25-25.
In `@website/versioned_docs/version-2.2.0/sections/create-entra-app.md`:
- Line 74: Update the changed sentence in create-entra-app.md to hyphenate the
compound modifier as “role-based access control (RBAC),” preserving the rest of
the sentence unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: bc73babc-078a-45e7-a1f5-a43a67ead802
📒 Files selected for processing (41)
build/aitools/test-metadata/test-results.jsonpowershell/assets/ReportTemplate.htmlpowershell/internal/Get-ObjectProperty.ps1powershell/internal/orca/check-ORCA205.ps1powershell/internal/orca/check-ORCA225.ps1powershell/internal/orca/check-ORCA234.ps1powershell/internal/orca/orcaClass.psm1powershell/public/Get-MtAuthenticationMethodPolicyConfig.ps1powershell/public/cisa/entra/Test-MtCisaPermanentRoleAssignment.ps1powershell/public/cisa/entra/Test-MtCisaRequireActivationApproval.ps1powershell/public/cisa/entra/Test-MtCisaUnmanagedRoleAssignment.ps1powershell/public/cisa/exchange/ConvertFrom-MailAuthenticationRecordDmarc.ps1powershell/public/cisa/exchange/Test-MtCisaDmarcReport.ps1powershell/public/maester/entra/Test-MtDeviceRegistrationMfaConflict.ps1powershell/public/maester/exchange/Test-MtLimitOnMicrosoftDomainUsage.mdpowershell/public/maester/intune/Test-MtManagedDeviceCleanupSettings.ps1powershell/public/orca/Test-ORCA225.mdpowershell/public/orca/Test-ORCA234.mdreport/src/lib/testResults.tswebsite/blog/2025-08-16-compensating-controls/index.mdwebsite/docs/commands/Get-MtAuthenticationMethodPolicyConfig.mdxwebsite/docs/commands/Test-MtCisaDmarcReport.mdxwebsite/docs/commands/Test-MtCisaPermanentRoleAssignment.mdxwebsite/docs/commands/Test-MtCisaRequireActivationApproval.mdxwebsite/docs/commands/Test-MtCisaUnmanagedRoleAssignment.mdxwebsite/docs/monitoring/azure-container-app-job.mdwebsite/docs/sections/create-entra-app.mdwebsite/docs/tests/maester/MT.1074.mdwebsite/docs/tests/orca/ORCA.225.mdwebsite/docs/tests/orca/ORCA.234.mdwebsite/src/css/custom.csswebsite/versioned_docs/version-2.2.0/commands/Get-MtAuthenticationMethodPolicyConfig.mdxwebsite/versioned_docs/version-2.2.0/commands/Test-MtCisaDmarcReport.mdxwebsite/versioned_docs/version-2.2.0/commands/Test-MtCisaPermanentRoleAssignment.mdxwebsite/versioned_docs/version-2.2.0/commands/Test-MtCisaRequireActivationApproval.mdxwebsite/versioned_docs/version-2.2.0/commands/Test-MtCisaUnmanagedRoleAssignment.mdxwebsite/versioned_docs/version-2.2.0/monitoring/azure-container-app-job.mdwebsite/versioned_docs/version-2.2.0/sections/create-entra-app.mdwebsite/versioned_docs/version-2.2.0/tests/maester/MT.1074.mdwebsite/versioned_docs/version-2.2.0/tests/orca/ORCA.225.mdwebsite/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md
| "TestTitle": "ORCA.234: Click through is disabled for Safe Documents.", | ||
| "TestResult": "Well done! Click through is disabled for Safe Documents.\n\n\n\n|Safe Attachments Policy|Setting|Current Value|Result|\n|-|-|-|-|\n|Default|AllowSafeDocsOpen|False|✅ Pass|\n", | ||
| "TestDescription": "Safe Documents can assist protecting files opened in Office appplications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View.\n\n#### Remediation action\nDo not let usres click through Protected View if Safe Documents identified the file as malicious.\n\n#### Related Links\n\n* [Microsoft 365 Defender Portal - Safe attachments](https://security.microsoft.com/safeattachmentv2) \n* [Recommended settings for EOP and Microsoft Defender for Office 365](https://aka.ms/orca-atpp-docs-7) \n* [Safe Documents in Microsoft 365 E5](https://aka.ms/orca-atpp-docs-1)\n", | ||
| "TestDescription": "Safe Documents can assist protecting files opened in Office applications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View.\n\n#### Remediation action\nDo not let usres click through Protected View if Safe Documents identified the file as malicious.\n\n#### Related Links\n\n* [Microsoft 365 Defender Portal - Safe attachments](https://security.microsoft.com/safeattachmentv2) \n* [Recommended settings for EOP and Microsoft Defender for Office 365](https://aka.ms/orca-atpp-docs-7) \n* [Safe Documents in Microsoft 365 E5](https://aka.ms/orca-atpp-docs-1)\n", |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the remaining ORCA.234 typos at the source.
This generated description still contains Pretected View and usres. Correct those strings in powershell/internal/orca/check-ORCA234.ps1, then regenerate this metadata so the report output matches the typo-fix objective.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@build/aitools/test-metadata/test-results.json` at line 13416, Correct the
remaining ORCA.234 source typos in the check-ORCA234.ps1 description, changing
“Pretected View” to “Protected View” and “usres” to “users.” Then regenerate
test-results.json so the generated metadata reflects the corrected source text.
| at Invoke-Pester<End>, /Users/merill/.local/share/powershell/Modules/Pester/5.5.0/Pester.psm1: line 5046 | ||
| at Invoke-Maester, /Users/merill/GitHub/maester/powershell/public/Invoke-Maester.ps1: line 448 | ||
| at <ScriptBlock>, <No file>: line 1`,PipelineIterationInfo:[]}],Block:`ORCA`,Duration:`00:00:00`,ResultDetail:{TestTitle:`ORCA.234: Click through is disabled for Safe Documents.`,SkippedReason:`Not connected to Exchange Online. See [Connecting to Exchange Online](https://maester.dev/docs/connect-maester/#connect-to-azure-exchange-online-and-teams)`,TestDescription:`Safe Documents can assist protecting files opened in Office appplications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View. | ||
| at <ScriptBlock>, <No file>: line 1`,PipelineIterationInfo:[]}],Block:`ORCA`,Duration:`00:00:00`,ResultDetail:{TestTitle:`ORCA.234: Click through is disabled for Safe Documents.`,SkippedReason:`Not connected to Exchange Online. See [Connecting to Exchange Online](https://maester.dev/docs/connect-maester/#connect-to-azure-exchange-online-and-teams)`,TestDescription:`Safe Documents can assist protecting files opened in Office applications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View. |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add “to” in the click-through sentence.
“Allow users click through Protected View” is ungrammatical; change it to “allow users to click through Protected View.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@powershell/assets/ReportTemplate.html` at line 16286, Update the Safe
Documents description in the ORCA.234 test result to change “allow users click
through Protected View” to “allow users to click through Protected View,”
preserving the surrounding text.
| $this.PassText="Click through is disabled for Safe Documents" | ||
| $this.FailRecommendation="Do not let usres click through Protected View if Safe Documents identified the file as malicious" | ||
| $this.Importance="Safe Documents can assist protecting files opened in Office appplications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View." | ||
| $this.Importance="Safe Documents can assist protecting files opened in Office applications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View." |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== locate files =="
git ls-files | rg '(^|/)(check-ORCA234\.ps1|Update-OrcaTests\.ps1)$|orca|Safe Documents|Pretected|Protected' || true
echo "== target file line =="
if [ -f "powershell/internal/orca/check-ORCA234.ps1" ]; then
wc -l powershell/internal/orca/check-ORCA234.ps1
sed -n '1,80p' powershell/internal/orca/check-ORCA234.ps1 | cat -n
fi
echo "== occurrences =="
rg -n "Pretected|Protected View|Safe Documents|allow users(click through| to click through)" powershell build test . --glob '!*.lock' --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**' 2>/dev/null || true
echo "== generate/update scripts outline/context =="
for f in $(git ls-files | rg '(^|/)Update-OrcaTests\.ps1$|build/orca'); do
echo "--- $f"
wc -l "$f"
rg -n "ORCA234|Importance|Safe|Protected|Check|Ps1|output|Out-File|Set-Content" "$f" -C 3 || true
doneRepository: maester365/maester
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== update script size/status =="
wc -l build/orca/Update-OrcaTests.ps1
file build/orca/Update-OrcaTests.ps1
echo "== imports/header =="
sed -n '1,120p' build/orca/Update-OrcaTests.ps1 | cat -n
echo "== ORCA234/source references =="
rg -n '234|ORCA234|SafeDocs|AllowSafeDocs|Pretected|Protected View|allow users|usres|usersres' build/orca/Update-OrcaTests.ps1 -C 4
echo "== all tracked 234 files with typo/text summaries =="
python3 - <<'PY'
from pathlib import Path
patterns = ['Pretected','Pretect','allow users click through','allow users to click through','usres','usersres']
files = [
Path('powershell/internal/orca/check-ORCA234.ps1'),
Path('powershell/public/orca/Test-ORCA234.md'),
Path('powershell/public/orca/Test-ORCA234.ps1'),
Path('website/docs/tests/orca/ORCA.234.md'),
Path('website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md'),
Path('tests/orca/Test-ORCA234.Tests.ps1'),
]
for p in files:
print(f'--- {p}')
if p.exists():
for i,line in enumerate(p.read_text(errors='replace').splitlines(),1):
if any(pat in line for pat in patterns) or any(x in line for x in ['FailRecommendation','ResultDetail','Do not let']):
print(f'{i}: {line}')
else:
print('missing')
PYRepository: maester365/maester
Length of output: 266
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== update script imports/header =="
sed -n '1,140p' build/orca/Update-OrcaTests.ps1 | cat -n
echo "== ORCA234/source references in update script =="
rg -n '234|ORCA234|SafeDocs|AllowSafeDocs|Pretected|Protected View|allow users|usres|usersres' build/orca/Update-OrcaTests.ps1 -C 4
echo "== all tracked 234 files with typo/text summaries =="
python3 - <<'PY'
from pathlib import Path
patterns = ['Pretected', 'Pretect', 'allow users click through', 'allow users to click through', 'usres', 'usersres']
files = [
Path('powershell/internal/orca/check-ORCA234.ps1'),
Path('powershell/public/orca/Test-ORCA234.md'),
Path('powershell/public/orca/Test-ORCA234.ps1'),
Path('website/docs/tests/orca/ORCA.234.md'),
Path('website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md'),
Path('tests/orca/Test-ORCA234.Tests.ps1'),
]
for p in files:
print(f'--- {p}')
if p.exists():
for i,line in enumerate(p.read_text(errors='replace').splitlines(),1):
if any(pat in line for pat in patterns) or any(x in line for x in ['FailRecommendation','ResultDetail','Do not let','Remediation']):
print(f'{i}: {line}')
else:
print('missing')
PYRepository: maester365/maester
Length of output: 7632
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== rest of update script =="
sed -n '139,410p' build/orca/Update-OrcaTests.ps1 | cat -n
echo "== ORCA234 text in generated/source files =="
python3 - <<'PY'
from pathlib import Path
files = [
'powershell/internal/orca/check-ORCA234.ps1',
'powershell/public/orca/Test-ORCA234.md',
'powershell/public/orca/Test-ORCA234.ps1',
'website/docs/tests/orca/ORCA.234.md',
'website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md',
'tests/orca/Test-ORCA234.Tests.ps1',
]
for p in files:
p=Path(p)
print(f'--- {p}')
if p.exists():
for i,line in enumerate(p.read_text(errors='replace').splitlines(),1):
if any(x in line for x in ['Pretected','Pretect','users click through',
'users to click through','usres','usersres','Remediation','Do not let']):
print(f'{i}: {line}')
PYRepository: maester365/maester
Length of output: 15618
🌐 Web query:
ORCA GitHub cammurray ORCA check-ORCA234 $this.Importance AllowSafeDocsOpen
💡 Result:
ORCA (the Microsoft Defender for Office 365 Recommended Configuration Analyzer) is a PowerShell-based tool created by Cam Murray [1][2][3] to help administrators identify and resolve configuration issues within Microsoft Defender for Office 365 [1][4]. The components you mentioned relate to different technical contexts: 1. ORCA GitHub Repository: The official repository for the tool is maintained by Cam Murray at https://github.com/cammurray/orca [1][4]. 2. check-ORCA234: ORCA uses individual PowerShell scripts for its rule checks (e.g., check-ORCA180.ps1) [5]. The reference to check-ORCA234 likely refers to a specific rule ID within the tool's check library [5]. 3. AllowSafeDocsOpen: This is not a parameter or component of the ORCA tool itself. Instead, it is a parameter used in the Exchange Online PowerShell cmdlet Set-AtpPolicyForO365 [6][7]. It is used to configure the Safe Documents feature in Microsoft 365, allowing or preventing users from exiting Protected View to open a document that has been identified as malicious [6][7]. In summary, ORCA is a diagnostic tool used to audit security configurations [1][4], while AllowSafeDocsOpen is a specific configuration setting for the Safe Documents security feature, which one might audit using the insights provided by ORCA [6][7].
Citations:
- 1: https://github.com/cammurray/orca
- 2: https://github.com/cammurray/orca/blob/master/ORCA.psm1
- 3: https://github.com/cammurray
- 4: https://github.com/cammurray/orca/blob/master/README.md
- 5: https://github.com/cammurray/orca/blob/master/Checks/check-ORCA180.ps1
- 6: https://learn.microsoft.com/en-gb/defender-office-365/safe-documents-in-e5-plus-security-about
- 7: https://learn.microsoft.com/da-dk/defender-office-365/safe-documents-in-e5-plus-security-about
Fix ORCA234 source text in the ORCA source repository.
The generated ORCA234 text still says allow users click through and Pretected View; should be allow users to click through and Protected View. The generated files copy this.Importance from build\orca\orca\Checks\check-ORCA234.ps1, so apply the source change there and regenerate. The existing usres typo in $this.FailRecommendation should be cleaned up as well.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@powershell/internal/orca/check-ORCA234.ps1` at line 37, Update the ORCA234
source definition in the source repository’s check-ORCA234.ps1: correct “allow
users click through” to “allow users to click through,” fix “Pretected View” to
“Protected View,” and clean up the “usres” typo in $this.FailRecommendation.
Regenerate the generated ORCA234 files from the corrected source so all copies
match.
| @@ -1,4 +1,4 @@ | |||
| Safe Documents can assist protecting files opened in Office appplications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View. | |||
| Safe Documents can assist protecting files opened in Office applications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View. | |||
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the remaining spelling and grammar errors.
Line 1 still says Pretected View; it should be Protected View. Also change “allow users click through” to “allow users to click through.”
🧰 Tools
🪛 LanguageTool
[grammar] ~1-~1: Ensure spelling is correct
Context: ...ocuments to not let users click through Pretected View. #### Remediation action Do not l...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@powershell/public/orca/Test-ORCA234.md` at line 1, Correct the wording in
Test-ORCA234’s description by changing “Pretected View” to “Protected View” and
revising “allow users click through” to “allow users to click through.”
Source: Linters/SAST tools
Comment on lines
7905
to
7908
| "TestTitle": "MT.1074: Ensure no more then 100 outbound mails per day are send using the .onmicrosoft.com domain", | ||
| "SkippedReason": null, | ||
| "TestDescription": "Ensure none or less than 100 outbound mails per day are being sent using the .onmicrosoft.com domain.\n\nLimitations of free 'onmicrosoft' shared domains:\\\nThe \"default\" onmicrosoft domains are useful for testing mail flow but are not suitable for regular messaging. They do not reflect a customer's brand identity and offer limited administrative control. Moreover, because these domains all share the 'onmicrosoft' domain (for example, 'contoso.onmicrosoft.com'), their reputation is collectively impacted. Despite Microsoft's efforts to minimize abuse, spammers often exploit newly created tenants to send bursts of spam from '.onmicrosoft.com' addresses before they can intervene. This degrades this shared domain's reputation, affecting all legitimate users. To ensure brand trust and email deliverability, organizations should establish and use their own custom domains for sending email. Until now, Microsoft did not have any limits on use of MOERA domains for email delivery.\n\nIntroducing new throttling enforcement:\\\nTo **prevent misuse and help improve deliverability** of customer email by encouraging best practices, Microsoft is changing its policy. In the future, MOERA domains should only be used for testing purposes, not regular email sending. Microsoft will be **introducing throttling to limit messages** sent from 'onmicrosoft.com' domains to **100 external recipients per organization per 24 hour** rolling window. Inbound messages won't be affected. External recipients are counted after the expansion of any of the original recipients. When a sender hits the throttling limit, they will receive NDRs with the code **550 5.7.236** for any attempts to send to external recipients while the tenant is throttled.\n\nRollout timeline:\\\n| MOERA outgoing email throttling starts | Exchange seats in the tenant |\n| --- | --- |\n| October 15, 2025 | Trial |\n| December 1, 2025 | < 3 |\n| January 7, 2026 | 3 - 10 |\n| February 2, 2026 | 11 - 50 |\n| March 2, 2026 | 51 - 200 |\n| April 1, 2026 | 201 - 2.000 |\n| May 4, 2026 | 2.001 - 10.000 |\n| June 1, 2026 | 10.001 > |\n\nPost origin from Exchange Team Blog, check your Message Center for further information on this change. [Exchange Team Blog](https://techcommunity.microsoft.com/blog/exchange/limiting-onmicrosoft-domain-usage-for-sending-emails/4446167?WT.mc_id=M365-MVP-5003086)\n\n#### Remediation action:\n\nChange primary usage of the .onmicrosoft.com domain for mailboxes.\n1. Navigate to Exchange admin center [Exchange Admin Center](https://admin.exchange.microsoft.com/#/)\n2. Click to expand **Recipients** and select **Mailboxes**.\n3. Filter for mailboxes with the .onmicrosoft.com domain as a primary SMTP address.\n4. Select a mailbox to open its properties and click **Manage email address types**.\n5. Select **Add email address type** and add a new mail adress with your custom domain.\n6. Check **Set as primary email address**.\n7. Confirm with **Ok**.\n8. Repeat for every mailbox.\n\n#### Related links\n\n* [Exchange Admin Center](https://admin.exchange.microsoft.com/#/)\n* [Limiting Onmicrosoft Domain Usage for Sending Emails | Exchange Team Blog](https://techcommunity.microsoft.com/blog/exchange/limiting-onmicrosoft-domain-usage-for-sending-emails/4446167?WT.mc_id=M365-MVP-5003086)\n\n", | ||
| "TestDescription": "Ensure none or less than 100 outbound mails per day are being sent using the .onmicrosoft.com domain.\n\nLimitations of free 'onmicrosoft' shared domains:\\\nThe \"default\" onmicrosoft domains are useful for testing mail flow but are not suitable for regular messaging. They do not reflect a customer's brand identity and offer limited administrative control. Moreover, because these domains all share the 'onmicrosoft' domain (for example, 'contoso.onmicrosoft.com'), their reputation is collectively impacted. Despite Microsoft's efforts to minimize abuse, spammers often exploit newly created tenants to send bursts of spam from '.onmicrosoft.com' addresses before they can intervene. This degrades this shared domain's reputation, affecting all legitimate users. To ensure brand trust and email deliverability, organizations should establish and use their own custom domains for sending email. Until now, Microsoft did not have any limits on use of MOERA domains for email delivery.\n\nIntroducing new throttling enforcement:\\\nTo **prevent misuse and help improve deliverability** of customer email by encouraging best practices, Microsoft is changing its policy. In the future, MOERA domains should only be used for testing purposes, not regular email sending. Microsoft will be **introducing throttling to limit messages** sent from 'onmicrosoft.com' domains to **100 external recipients per organization per 24 hour** rolling window. Inbound messages won't be affected. External recipients are counted after the expansion of any of the original recipients. When a sender hits the throttling limit, they will receive NDRs with the code **550 5.7.236** for any attempts to send to external recipients while the tenant is throttled.\n\nRollout timeline:\\\n| MOERA outgoing email throttling starts | Exchange seats in the tenant |\n| --- | --- |\n| October 15, 2025 | Trial |\n| December 1, 2025 | < 3 |\n| January 7, 2026 | 3 - 10 |\n| February 2, 2026 | 11 - 50 |\n| March 2, 2026 | 51 - 200 |\n| April 1, 2026 | 201 - 2.000 |\n| May 4, 2026 | 2.001 - 10.000 |\n| June 1, 2026 | 10.001 > |\n\nPost origin from Exchange Team Blog, check your Message Center for further information on this change. [Exchange Team Blog](https://techcommunity.microsoft.com/blog/exchange/limiting-onmicrosoft-domain-usage-for-sending-emails/4446167?WT.mc_id=M365-MVP-5003086)\n\n#### Remediation action:\n\nChange primary usage of the .onmicrosoft.com domain for mailboxes.\n1. Navigate to Exchange admin center [Exchange Admin Center](https://admin.exchange.microsoft.com/#/)\n2. Click to expand **Recipients** and select **Mailboxes**.\n3. Filter for mailboxes with the .onmicrosoft.com domain as a primary SMTP address.\n4. Select a mailbox to open its properties and click **Manage email address types**.\n5. Select **Add email address type** and add a new mail address with your custom domain.\n6. Check **Set as primary email address**.\n7. Confirm with **Ok**.\n8. Repeat for every mailbox.\n\n#### Related links\n\n* [Exchange Admin Center](https://admin.exchange.microsoft.com/#/)\n* [Limiting Onmicrosoft Domain Usage for Sending Emails | Exchange Team Blog](https://techcommunity.microsoft.com/blog/exchange/limiting-onmicrosoft-domain-usage-for-sending-emails/4446167?WT.mc_id=M365-MVP-5003086)\n\n", | ||
| "TestResult": "\nWell done. No more then 100 outbound mails has been send in the last 14 days using the .onmicrosoft.com domain.", |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the MT.1074 entry internally consistent.
The title and result still contain “more then” and “are send” (Lines 7905 and 7908), while the description uses “none or less than 100.” Correct the neighboring text and use one consistent threshold phrase, such as “no more than 100,” if 100 is allowed.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@report/src/lib/testResults.ts` around lines 7905 - 7908, Update the MT.1074
TestTitle and TestResult text to correct “then” to “than” and “send” to “sent,”
and use the same threshold wording as TestDescription, preferably “no more than
100” if the limit is inclusive. Keep the entry’s meaning and surrounding
description unchanged.
| "TestTitle": "ORCA.225: Safe Documents is enabled for Office clients.", | ||
| "SkippedReason": "Not connected to Exchange Online. See [Connecting to Exchange Online](https://maester.dev/docs/connect-maester/#connect-to-azure-exchange-online-and-teams)", | ||
| "TestDescription": "Safe Documents can assist protecting files opened in Office appplications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365.\n\n#### Remediation action\nEnable Safe Documents for Office clients.\n\n#### Related Links\n\n* [Microsoft 365 Defender Portal - Safe attachments](https://security.microsoft.com/safeattachmentv2) \n* [Recommended settings for EOP and Microsoft Defender for Office 365](https://aka.ms/orca-atpp-docs-7) \n* [Safe Documents in Microsoft 365 E5](https://aka.ms/orca-atpp-docs-1)\n", | ||
| "TestDescription": "Safe Documents can assist protecting files opened in Office applications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365.\n\n#### Remediation action\nEnable Safe Documents for Office clients.\n\n#### Related Links\n\n* [Microsoft 365 Defender Portal - Safe attachments](https://security.microsoft.com/safeattachmentv2) \n* [Recommended settings for EOP and Microsoft Defender for Office 365](https://aka.ms/orca-atpp-docs-7) \n* [Safe Documents in Microsoft 365 E5](https://aka.ms/orca-atpp-docs-1)\n", |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Proofread the synchronized Safe Documents descriptions together.
Both entries retain the copied grammar error “can assist protecting.”
report/src/lib/testResults.ts#L18893-L18893: change it to “can assist in protecting.”report/src/lib/testResults.ts#L19693-L19693: make the same grammar correction and fix “Pretected,” “usres,” and “allow users click through.”
📍 Affects 1 file
report/src/lib/testResults.ts#L18893-L18893(this comment)report/src/lib/testResults.ts#L19693-L19693
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@report/src/lib/testResults.ts` at line 18893, Correct the synchronized Safe
Documents descriptions in report/src/lib/testResults.ts at lines 18893-18893 and
19693-19693: change “can assist protecting” to “can assist in protecting” in
both entries, and additionally correct “Pretected,” “usres,” and “allow users
click through” in the latter entry.
| > 💡 Callout | ||
| > | ||
| > Governance terminology (e.g., frameworks, policies, standards, and more) gets used in many contexts with many different meanings. An example being the United States National Institute of Standards and Technology (NIST), which publishes standards and more. The NIST Special Publication (SP) 1800 series is a common example of **guidelines**. Often these NIST SPs may be referenced as standards though. Standards bodies exist for many different topics in many different ways, such as the OpenID Foundation (OIDF) creating identity standards that are secure, interoperable and privacy-preserving, or ASTM International offers resources for standards development and use worldwide. This illustrates a nuance as well for internal versus external standards. Where external standards are typically consensus driven by an industry working group aroud common specifications for implementations, and internal standards define specific requirements your organization has for implementations. | ||
| > Governance terminology (e.g., frameworks, policies, standards, and more) gets used in many contexts with many different meanings. An example being the United States National Institute of Standards and Technology (NIST), which publishes standards and more. The NIST Special Publication (SP) 1800 series is a common example of **guidelines**. Often these NIST SPs may be referenced as standards though. Standards bodies exist for many different topics in many different ways, such as the OpenID Foundation (OIDF) creating identity standards that are secure, interoperable and privacy-preserving, or ASTM International offers resources for standards development and use worldwide. This illustrates a nuance as well for internal versus external standards. Where external standards are typically consensus driven by an industry working group around common specifications for implementations, and internal standards define specific requirements your organization has for implementations. |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Tighten the changed paragraph’s grammar.
Use consensus-driven and rewrite the fragments beginning “An example being” and “Where external standards” as complete sentences.
🧰 Tools
🪛 LanguageTool
[style] ~45-~45: ‘many different ways’ might be wordy. Consider a shorter alternative.
Context: ...dies exist for many different topics in many different ways, such as the OpenID Foundation (OIDF) c...
(EN_WORDINESS_PREMIUM_MANY_DIFFERENT_WAYS)
[grammar] ~45-~45: Use a hyphen to join words.
Context: ...ternal standards are typically consensus driven by an industry working group arou...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/blog/2025-08-16-compensating-controls/index.md` at line 45, Update
the paragraph’s grammar by changing “consensus driven” to “consensus-driven,”
rewriting the sentence beginning “An example being” as a complete sentence, and
converting the fragment beginning “Where external standards” into a complete
sentence while preserving the existing meaning.
Source: Linters/SAST tools
| ### (Optional) Grant permissions to Azure | ||
|
|
||
| The Azure Role Based Access Control (RBAC) implementation utilizes Uniform Resource Names (URN) with a "/" separator for heirarchical scoping. There exists resources within the root (e.g., "/") scope that Microsoft retains strict control over by limiting supported interactions. As a Global Administrator you can [elevate access](https://learn.microsoft.com/en-us/azure/role-based-access-control/elevate-access-global-admin?tabs=powershell) to become authorized for these limited interactions. | ||
| The Azure Role Based Access Control (RBAC) implementation utilizes Uniform Resource Names (URN) with a "/" separator for hierarchical scoping. There exists resources within the root (e.g., "/") scope that Microsoft retains strict control over by limiting supported interactions. As a Global Administrator you can [elevate access](https://learn.microsoft.com/en-us/azure/role-based-access-control/elevate-access-global-admin?tabs=powershell) to become authorized for these limited interactions. |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Hyphenate “Role-Based Access Control.”
Use the standard compound form for consistency: “Azure Role-Based Access Control (RBAC) implementation.”
🧰 Tools
🪛 LanguageTool
[grammar] ~74-~74: Use a hyphen to join words.
Context: ...ant permissions to Azure The Azure Role Based Access Control (RBAC) implementati...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/docs/sections/create-entra-app.md` at line 74, Update the
introductory documentation sentence to use the standard hyphenated phrase “Azure
Role-Based Access Control (RBAC) implementation,” leaving the surrounding
wording unchanged.
Source: Linters/SAST tools
| ## Overview | ||
|
|
||
| Safe Documents can assist protecting files opened in Office appplications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View. | ||
| Safe Documents can assist protecting files opened in Office applications. Before a user is allowed to trust a file opened in Office 365 ProPlus using Protected View, the file will be verified by Microsoft Defender for Office 365. It is possible to allow users click through Protected View even if Safe Documents identified the file as malicious. It is recommended to configure Safe Documents to not let users click through Pretected View. |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix Pretected View consistently in both ORCA.234 pages.
website/docs/tests/orca/ORCA.234.md#L25-L25: replacePretected ViewwithProtected View.website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md#L25-L25: apply the same correction.
🧰 Tools
🪛 LanguageTool
[grammar] ~25-~25: Ensure spelling is correct
Context: ...ocuments to not let users click through Pretected View. #### Remediation action Do not l...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
📍 Affects 2 files
website/docs/tests/orca/ORCA.234.md#L25-L25(this comment)website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md#L25-L25
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/docs/tests/orca/ORCA.234.md` at line 25, Correct the typo “Pretected
View” to “Protected View” in both ORCA.234 pages:
website/docs/tests/orca/ORCA.234.md at lines 25-25 and
website/versioned_docs/version-2.2.0/tests/orca/ORCA.234.md at lines 25-25.
Source: Linters/SAST tools
| ### (Optional) Grant permissions to Azure | ||
|
|
||
| The Azure Role Based Access Control (RBAC) implementation utilizes Uniform Resource Names (URN) with a "/" separator for heirarchical scoping. There exists resources within the root (e.g., "/") scope that Microsoft retains strict control over by limiting supported interactions. As a Global Administrator you can [elevate access](https://learn.microsoft.com/en-us/azure/role-based-access-control/elevate-access-global-admin?tabs=powershell) to become authorized for these limited interactions. | ||
| The Azure Role Based Access Control (RBAC) implementation utilizes Uniform Resource Names (URN) with a "/" separator for hierarchical scoping. There exists resources within the root (e.g., "/") scope that Microsoft retains strict control over by limiting supported interactions. As a Global Administrator you can [elevate access](https://learn.microsoft.com/en-us/azure/role-based-access-control/elevate-access-global-admin?tabs=powershell) to become authorized for these limited interactions. |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Hyphenate the compound modifier.
Use role-based access control (RBAC) in the changed sentence.
🧰 Tools
🪛 LanguageTool
[grammar] ~74-~74: Use a hyphen to join words.
Context: ...ant permissions to Azure The Azure Role Based Access Control (RBAC) implementati...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/versioned_docs/version-2.2.0/sections/create-entra-app.md` at line
74, Update the changed sentence in create-entra-app.md to hyphenate the compound
modifier as “role-based access control (RBAC),” preserving the rest of the
sentence unchanged.
Source: Linters/SAST tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes #
✅ Checks
/powershell/tests/pester.ps1locally.ℹ️ Additional Information
How to Contribute
🏗️ Read our full contributing guide for the Maester project.
🧪 We also have additional instructions and a checklist for creating tests.
Join us at the Maester repository discussions or Entra Discord for more help and conversations!
While you wait for a review, why not spread some Maester love on social media? Thank you! 💖
Summary by CodeRabbit
Documentation
Bug Fixes