feat: Add Classical and Stacked Cox Regression algorithms#593
Open
AndreasKtenidis wants to merge 1 commit into
Open
feat: Add Classical and Stacked Cox Regression algorithms#593AndreasKtenidis wants to merge 1 commit into
AndreasKtenidis wants to merge 1 commit into
Conversation
AndreasKtenidis
force-pushed
the
feature/cox-regression
branch
from
d9eeb41 to
d49b8cc
Compare
ThanKarab
requested changes
May 29, 2026
Member
ThanKarab
left a comment
ThanKarab
left a comment
There was a problem hiding this comment.
Great work!
Minor adjustments needed.
Rebase and squash also needed.
| @@ -0,0 +1,17 @@ | |||
| from exaflow.algorithms.exareme3.classical_cox_regression import ClassicalCoxRegression | |||
Member
There was a problem hiding this comment.
Why isn't the algorithm inside here and is in another file?
| @@ -0,0 +1,274 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| @@ -0,0 +1,35 @@ | |||
| # Classical Cox Regression | |||
Member
There was a problem hiding this comment.
Rename cox_regression algorithms with the stacked and classical as suffix, not prefix, so it's easier to look for them.
So cox_regression_classical and cox_regression_stacked
AndreasKtenidis
force-pushed
the
feature/cox-regression
branch
2 times, most recently
from
256a49c to
45d76ac
Compare
AndreasKtenidis
force-pushed
the
feature/cox-regression
branch
from
45d76ac to
19de090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ...