fix(benchmark): share benchmark model manifest across web and API#723
Draft
madara88645 wants to merge 1 commit into
Draft
fix(benchmark): share benchmark model manifest across web and API#723madara88645 wants to merge 1 commit into
madara88645 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
web/app/benchmark/models.jsonfileWhat this does for the product
This keeps the benchmark model dropdown and the backend validator reading the same source of truth, so we avoid the situation where users can pick a model in the UI that the server later rejects.
Risk
Low. Scope is limited to benchmark model configuration and related tests.
Verification
py -3.12 -m pytest tests/test_benchmark_api.py -qnpm run test -- app/benchmark/page.test.tsxnode --test web/app/benchmark/modelCatalog.test.mts