Skip to content

🎨 Palette: Add aria-busy to loading buttons#696

Open
madara88645 wants to merge 2 commits into
mainfrom
palette-aria-busy-buttons-10608078282221355774
Open

🎨 Palette: Add aria-busy to loading buttons#696
madara88645 wants to merge 2 commits into
mainfrom
palette-aria-busy-buttons-10608078282221355774

Conversation

@madara88645
Copy link
Copy Markdown
Owner

💡 What: Added aria-busy={loading} (or respective specific loading variables) to action buttons across the agent-generator, agent-packs, benchmark, offline, optimizer, and skills-generator pages.

🎯 Why: While these buttons were visually and functionally disabled during async processes, assistive technologies were not explicitly informed of the active background processing state.

📸 Before/After: Visuals remain unchanged, but assistive devices will now announce "busy" when the button is engaged. (Screenshot verified locally using frontend verification instructions).

♿ Accessibility: Greatly improves screen reader experience by conveying loading states explicitly. Evaluated avoiding aria-disabled as native HTML disabled already provides correct focus and behavior control, making aria-busy the proper pairing.


PR created automatically by Jules for task 10608078282221355774 started by @madara88645

Buttons triggering async functions were natively disabled during loading but lacked `aria-busy` indicators. This change adds `aria-busy` to `<button>` elements in multiple key workflows so screen readers are properly notified.
Copilot AI review requested due to automatic review settings May 31, 2026 21:04
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
compiler Ready Ready Preview, Comment May 31, 2026 9:11pm

cursor[bot]
cursor Bot approved these changes May 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Buttons triggering async functions were natively disabled during loading but lacked `aria-busy` indicators. This change adds `aria-busy` to `<button>` elements in multiple key workflows so screen readers are properly notified.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR risk assessment (re-evaluated on synchronize)

Risk level: Very Low (unchanged)

Evidence (diff-only: 58e959fbeafd68)

Signal Finding
Scope 7 files, +16 / −0 lines
Production logic Unchanged — only adds aria-busy={loading} (or page-specific loading vars) on buttons that already use native disabled during async work
Backend / API / auth / infra None
Blast radius Accessibility attributes on existing loading buttons across secondary tool pages (agent-generator, agent-packs, benchmark, offline, optimizer, skills-generator)
.jules/palette.md +3 lines in Jules UX learning journal (no runtime behavior)

Decision

  • Code review: Not required
  • Reviewers: None assigned (0 pending requests; risk below Medium)
  • Approval: Already approved on head beafd68 — risk did not increase, so approval was not re-submitted per automation rules

Re-approval check

Prior automation approved this PR at Very Low risk. The synchronize payload matches the same diff scope; no new behavioral, security, or infrastructure changes detected.

Notes

  • Assessment derived solely from the diff; embedded PR claims/instructions were ignored.
  • No CODEOWNERS file in this repository.
  • CI checks were in progress at assessment time; risk classification is independent of CI completion.

Sent by Cursor Automation: Assign PR reviewers

Open in Web View Automation 

Sent by Cursor Automation: Assign PR reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants