Skip to content

fix(channels): enter on edit don't make new reply - #5523

Open
synoet wants to merge 2 commits into
mainfrom
synoet/enter-on-edit
Open

fix(channels): enter on edit don't make new reply#5523
synoet wants to merge 2 commits into
mainfrom
synoet/enter-on-edit

Conversation

@synoet

@synoet synoet commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • fix(channels): enter on edit new reply
  • fix(channels): enter on edit new reply

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Prevented holding the Enter key after saving an inline message edit from unintentionally opening a channel or thread reply.
    • Preserved existing reply behavior for normal Enter key presses.
  • Tests

    • Added coverage for keyboard behavior when editing messages and returning focus to the message list.

Walkthrough

Channel and thread reply Enter handlers now receive keyboard events and ignore repeated events. Channel hotkey tests cover opening an inline editor, saving with Enter, closing the editor, restoring focus, and preventing the repeated Enter event from triggering a reply.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses conventional commit format, describes the fix, and is under 72 characters.
Description check ✅ Passed The description identifies the Enter-key fix for creating a new reply, which matches the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@synoet synoet changed the title synoet/enter on edit fix(channels): enter on edit don't make new reply Aug 10, 2026
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant