chore: no more local onboarding

[404Wolf]

No description provided.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a9d636f0-7522-41b8-b948-f3fd710aa557

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Summary by CodeRabbit

• Improvements
  • Development mode now bypasses onboarding redirects and setup screens.
  • Authentication flows remain accessible without onboarding checks while developing.
  • Existing authentication, routing, mobile, and production onboarding behavior is unchanged.

Walkthrough

The web application imports DEV_MODE_ENV into layout, authentication, and root route logic. When development mode is enabled, onboarding redirects are skipped, authentication does not wait for or enter onboarding, and SetupRoute and OnboardingRoute redirect to /. Existing onboarding behavior remains unchanged outside development mode.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, so its relevance to the changeset cannot be assessed.	Add a brief description of the development-mode changes that disable local onboarding redirects.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses conventional commits format, is under 72 characters, and accurately describes the onboarding changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Preview: https://wolf-no-local-onboard-sydjs3.preview.macro.com/app (5d04365)

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/web/src/routes/Root.tsx`:
- Around line 318-319: Update InitialInteractiveOnboardingModal’s modalOpen()
expression in Root.tsx to require !DEV_MODE_ENV, preventing the modal from
opening in development mode while preserving the existing mobile and
feature-flag conditions. Add regression coverage verifying the modal remains
closed when DEV_MODE_ENV is enabled.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d9b1e42c-9a5a-40fe-b4c7-60aa04d9f8af

📥 Commits

Reviewing files that changed from the base of the PR and between 8480d35 and b82fb3c.

📒 Files selected for processing (4)

• apps/web/src/components/app/Layout.tsx
• apps/web/src/features/auth/EmailAuth.tsx
• apps/web/src/features/auth/Login.tsx
• apps/web/src/routes/Root.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Guard InitialInteractiveOnboardingModal in development mode.

These route guards cover direct /setup and /onboarding entry, but InitialInteractiveOnboardingModal is still mounted from apps/web/src/routes/Root.tsx Line [735]. Its modalOpen() expression at Lines [620]-[628] has no DEV_MODE_ENV check. A first-time non-native mobile user still satisfies isMobile(). A desktop user still satisfies the flag-off branch after the flag resolves. Both cases can open onboarding in development mode.

Add !DEV_MODE_ENV to modalOpen() and add regression coverage for development mode.

Proposed fix

  const modalOpen = () =>
    open() &&
+   !DEV_MODE_ENV &&
    // Onboarding-v4 replaces this modal on desktop; the Layout redirect

Also applies to: 337-338

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/routes/Root.tsx` around lines 318 - 319, Update
InitialInteractiveOnboardingModal’s modalOpen() expression in Root.tsx to
require !DEV_MODE_ENV, preventing the modal from opening in development mode
while preserving the existing mobile and feature-flag conditions. Add regression
coverage verifying the modal remains closed when DEV_MODE_ENV is enabled.

[synoet]

This would disable onboarding in dev, which I don't think we want. I think instead we should have an env feature flag which gets set when you use just run_local

[404Wolf]

This would disable onboarding in dev, which I don't think we want. I think instead we should have an env feature flag which gets set when you use just run_local

I switched to LOCAL_ONLY, I think that does what we want

[synoet]

This should be its own nob. You can use the existing feature flag and tune it to resolve to false when local is running. That way if someone does want to test it locally it is easy to turn back on.