Add memory conflict review workflow - #1
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
macayu17
marked this pull request as ready for review
July 18, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Engram previously replaced selected memories in place when reconciliation returned
UPDATE, which could silently erase a still-valid durable claim. This keeps clear corrections automatic while holding genuine conflicts out of retrieval until the user resolves them.Impact
Unresolved proposals remain pending and excluded from approved-only retrieval. Users can accept the new claim, keep the current claim, or keep both from the Memories dashboard. No Azure, Docker, deployment, model, or environment configuration changes are included.
Validation
F:\Engram\.venv\Scripts\python.exe -m pytest api -q(162 passed, 3 skipped)npm run typechecknpm run verify:logicnpm run verify:conflictsnpm run builddocker compose config --quiet